New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gcc-jit coverage to the valgrind test suite #12818
Conversation
Thank you for working on that. Few comments I have:
Btw. these are known false positives.
|
ae6cb97
to
c31cdfb
Compare
Indeed, it makes perhaps more sense to move this to an additional test gcc.pm. I've moved it there and updated the schedule for Tumbleweed accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would also add a cleanup function (in the perl side) but all looks good otherwise, nice library!
What kind of cleanup are you thinking of? I don't see much potential for cleanup or do you mean to just put the skeleton code there? |
Nothing special, just deleting the source file and binary. But again, no strong opinion on it |
On request of Martin Liska, adding coverage to the gcc-jit compiler within the valgrind test suite. This test will run on openSUSE Tumbleweed only, as the feature is quiet new and not applicable yet to SLES.
On request adding coverage to the gcc-jit compiler within the valgrind test suite.
This test will run on openSUSE Tumbleweed only, as the feature is quiet new and not applicable yet to SLES.