Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle UEFI Firmware Settings for grub_auth test #12932

Merged
merged 1 commit into from Jul 21, 2021
Merged

Handle UEFI Firmware Settings for grub_auth test #12932

merged 1 commit into from Jul 21, 2021

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Jul 20, 2021

With update to grub 2.06 in Tumbleweed, a new menu
entry has been added: 'UEFI Firmware settings'.
So, the test needs to be updated for Tumbleweed.

@rfan1
Handle UEFI Firmware Settings for grub_auth test
9a083f4 
With update to grub 2.06 in Tumbleweed, a new menu
entry has been added: 'UEFI Firmware settings'.
So, the test needs to be updated for Tumbleweed.
@rfan1
Copy link
Contributor Author

rfan1 commented Jul 20, 2021

@okurz @Amrysliu

Please kindly help review my new PR again :)

Amrysliu
Amrysliu approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@Amrysliu Amrysliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jouyingbin
jouyingbin approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

okurz
okurz reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rfan1
Copy link
Contributor Author

rfan1 commented Jul 21, 2021

+1

Thanks Oliver!

@Amrysliu Amrysliu merged commit 437f4c1 into os-autoinst:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okurz okurz okurz left review comments

@jouyingbin jouyingbin jouyingbin approved these changes

@Amrysliu Amrysliu Amrysliu approved these changes

@lemon-suse lemon-suse lemon-suse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@rfan1 @okurz @jouyingbin @Amrysliu @lemon-suse