Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change_password and snapper_rollback failure #12965

Merged
merged 1 commit into from Jul 27, 2021

Conversation

GraceWang571
Copy link
Contributor

@GraceWang571 GraceWang571 commented Jul 23, 2021

Update handle_login in x11utils.pm to allow user defined password
Update logout_and_login in users.pm to use handle_login
Update snapper_rollback.pm to handle gnome-activities

Related ticket: https://progress.opensuse.org/issues/95789
Update handle_login in x11utils.pm to allow user defined password
Update logout_and_login in users.pm to use handle_login
Update snapper_rollback.pm to handle gnome-activities
@lemon-suse
Copy link
Contributor

I just reviewed the code related with users, I think it is good for me. Just please run a verification log on migration test, ex: https://openqa.nue.suse.com/tests/5991320 Sometimes it will fail on the login issue.

@GraceWang571
Copy link
Contributor Author

GraceWang571 commented Jul 23, 2021

I just reviewed the code related with users, I think it is good for me. Just please run a verification log on migration test, ex: https://openqa.nue.suse.com/tests/5991320 Sometimes it will fail on the login issue.

Thanks for the reminder.
Just cloned the migration job, let's see the result of https://openqa.suse.de/tests/6533593

@lemon-suse
Copy link
Contributor

I just reviewed the code related with users, I think it is good for me. Just please run a verification log on migration test, ex: https://openqa.nue.suse.com/tests/5991320 Sometimes it will fail on the login issue.

Thanks for the reminder.
Just cloned the migration job, let see the result of https://openqa.suse.de/tests/6533593

Sorry, I forgot the registration code updated. I will send it to you by mail.

@GraceWang571
Copy link
Contributor Author

GraceWang571 commented Jul 26, 2021

@lemon-suse Finally, I got a relatively "good" result from openQA. (I think the bootloader.pm is not stable, it fails 3 out of 4 times)
https://openqa.suse.de/tests/6567207

@lemon-suse lemon-suse merged commit e15d237 into os-autoinst:master Jul 27, 2021
@GraceWang571 GraceWang571 deleted the pr12883omission branch October 22, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants