Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers: schedule buildah tests only in 1 place #13004

Closed
wants to merge 1 commit into from
Closed

Containers: schedule buildah tests only in 1 place #13004

wants to merge 1 commit into from

Conversation

jlausuch
Copy link
Contributor

For some reason we were scheduling buildah tests in
engines and tools and also in sle image on sle host.
Let's just run it in single place.

@jlausuch jlausuch requested review from b10n1k and pdostal July 30, 2021 10:34
Copy link
Member

@pdostal pdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand where will we be running podman after this PR.

For some reason we were scheduling buildah tests in
engines and tools and also in sle image on sle host.
Let's just run it in single place.
@jlausuch
Copy link
Contributor Author

jlausuch commented Jul 30, 2021

I don't understand where will we be running podman after this PR.

it is still here ... there was some mess after the refactor we did with the yaml schedules.. so podman/docker will be run in engines_and_tools and podman_image/docker_image in sle_image_on_... together with buildah_podman/buildah_docker

Copy link
Member

@pdostal pdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jlausuch 🎉

@jlausuch
Copy link
Contributor Author

Let's first decide https://progress.opensuse.org/issues/96383

Copy link
Contributor

@b10n1k b10n1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i am not wrong this commit removes buildah from the host testing. i thought we want the opposite.

#13021

@jlausuch
Copy link
Contributor Author

jlausuch commented Aug 4, 2021

if i am not wrong this commit removes buildah from the host testing. i thought we want the opposite.

#13021

indeed, this was done before discussing. Closing it.

@jlausuch jlausuch closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants