Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate netfilter of audit test into openQA #13067

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

Amrysliu
Copy link
Contributor

@Amrysliu Amrysliu commented Aug 13, 2021

QE security team plans to integrate audit-test into openQA, netfilter is one test case of it.
netfilter is a multi-machine test.

Related: https://progress.opensuse.org/issues/96540
Verification run: https://openqa.suse.de/tests/6869802# (client)
https://openqa.suse.de/tests/6869801# (server)
MR: https://gitlab.suse.de/security/audit-test-sle15/-/merge_requests/23

@Amrysliu Amrysliu force-pushed the integrate_netfilter branch 2 times, most recently from 78e7879 to 28dd9be Compare August 13, 2021 11:28
lib/audit_test.pm Outdated Show resolved Hide resolved
@lilyeyes
Copy link
Contributor

lilyeyes commented Aug 16, 2021

Please add the VR (for both client and server) and MR for this PR :)

@Amrysliu
Copy link
Contributor Author

Please add the VR (for both client and server) and MR for this PR :)

Added

Copy link
Contributor

@tinawang123 tinawang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lib/audit_test.pm Outdated Show resolved Hide resolved
QE security team plans to integrate audit-test into openQA, netfilter is
one test case of it.
Netfilter is a multi-machine test.

Related: https://progress.opensuse.org/issues/96540
In netfilter test, there are two pairs of  test cases have the same name:
```
[9] accept__remote_unlabeled_ipv4_fail_subj_eq_obj
[59] accept__remote_unlabeled_ipv4_fail_subj_eq_obj

[11] accept__remote_unlabeled_ipv6_fail_subj_eq_obj
[61] accept__remote_unlabeled_ipv6_fail_subj_eq_obj
```
So we can't use the name of test case as the hash key.
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great To Me. Thanks for the case. :-) Learnt it.

@Amrysliu Amrysliu merged commit 4daede8 into os-autoinst:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants