-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate netfilter of audit test into openQA #13067
Conversation
78e7879
to
28dd9be
Compare
Please add the VR (for both client and server) and MR for this PR :) |
28dd9be
to
1bff6fe
Compare
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
QE security team plans to integrate audit-test into openQA, netfilter is one test case of it. Netfilter is a multi-machine test. Related: https://progress.opensuse.org/issues/96540
In netfilter test, there are two pairs of test cases have the same name: ``` [9] accept__remote_unlabeled_ipv4_fail_subj_eq_obj [59] accept__remote_unlabeled_ipv4_fail_subj_eq_obj [11] accept__remote_unlabeled_ipv6_fail_subj_eq_obj [61] accept__remote_unlabeled_ipv6_fail_subj_eq_obj ``` So we can't use the name of test case as the hash key.
1bff6fe
to
8d7b0e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great To Me. Thanks for the case. :-) Learnt it.
QE security team plans to integrate audit-test into openQA, netfilter is one test case of it.
netfilter is a multi-machine test.
Related: https://progress.opensuse.org/issues/96540
Verification run: https://openqa.suse.de/tests/6869802# (client)
https://openqa.suse.de/tests/6869801# (server)
MR: https://gitlab.suse.de/security/audit-test-sle15/-/merge_requests/23