Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: Switch kexec test to select_serial_terminal #13088

Merged
merged 1 commit into from Aug 18, 2021

Conversation

czerw
Copy link
Contributor

@czerw czerw commented Aug 18, 2021

Fix poo#97004: Use select_serial_terminal instead of root console to
make test more robust. Test maintainer was updated.

@czerw
Copy link
Contributor Author

czerw commented Aug 18, 2021

@mdoucha @pevik please check

@mdoucha
Copy link
Contributor

mdoucha commented Aug 18, 2021

It looks good but select_serial_terminal() after kexec will only wait 95 seconds for login prompt. Do you think it'll be enough in all cases?

@czerw czerw changed the title kernel: Switch kexec test to select_serial_terminal [wip] kernel: Switch kexec test to select_serial_terminal Aug 18, 2021
@pevik
Copy link
Contributor

pevik commented Aug 18, 2021

It looks good but select_serial_terminal() after kexec will only wait 95 seconds for login prompt. Do you think it'll be enough in all cases?

Good point, but shouldn't this be handled somewhere in https://github.com/os-autoinst/os-autoinst/blob/master/consoles/serial_screen.pm or https://github.com/os-autoinst/os-autoinst/blob/master/consoles/virtio_terminal.pm (add proper timeout based on backend/arch?)
I suppose one of them handles the timeout. Or is the timeout based on needles setup?

@mdoucha
Copy link
Contributor

mdoucha commented Aug 18, 2021

This is normally handled by wait_boot() which ensures that the system will be fully booted before calling select_serial_terminal(). But kexec bypasses Grub so $self->wait_boot_past_bootloader() would be the correct method to call here.

Fix poo#97004: Use select_serial_terminal instead of root console to
make test more robust. Test maintainer was updated.
@czerw czerw changed the title [wip] kernel: Switch kexec test to select_serial_terminal kernel: Switch kexec test to select_serial_terminal Aug 18, 2021
@czerw
Copy link
Contributor Author

czerw commented Aug 18, 2021

Added missing $self->wait_boot_past_bootloader() and updated verifications in description.

Copy link
Contributor

@mdoucha mdoucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pevik pevik merged commit 4feb5fd into os-autoinst:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants