Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETFILTER_PKT test fix in ip_eb_tables #13203

Merged
merged 1 commit into from
Sep 9, 2021
Merged

NETFILTER_PKT test fix in ip_eb_tables #13203

merged 1 commit into from
Sep 9, 2021

Conversation

vtrubovics
Copy link
Contributor

@vtrubovics vtrubovics mentioned this pull request Sep 7, 2021
Closed
@rfan1
Copy link
Contributor

rfan1 commented Sep 8, 2021

Viktor,

Minor comment, "POO97076 NETFILTER_PKT test fix in ip_eb_tables" to "NETFILTER_PKT test fix in ip_eb_tables"

@lilyeyes
Copy link
Contributor

lilyeyes commented Sep 8, 2021

Viktor,

Minor comment, "POO97076 NETFILTER_PKT test fix in ip_eb_tables" to "NETFILTER_PKT test fix in ip_eb_tables"

@vtrubovics FYI: https://chris.beams.io/posts/git-commit/

@vtrubovics vtrubovics changed the title POO97076 NETFILTER_PKT test fix in ip_eb_tables NETFILTER_PKT test fix in ip_eb_tables Sep 8, 2021
@vtrubovics
Copy link
Contributor Author

Viktor,
Minor comment, "POO97076 NETFILTER_PKT test fix in ip_eb_tables" to "NETFILTER_PKT test fix in ip_eb_tables"

@vtrubovics FYI: https://chris.beams.io/posts/git-commit/

Fixed

rfan1
rfan1 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the fix

@jouyingbin
Copy link
Contributor

jouyingbin commented Sep 9, 2021 •
edited
Loading

Viktor,
Minor comment, "POO97076 NETFILTER_PKT test fix in ip_eb_tables" to "NETFILTER_PKT test fix in ip_eb_tables"

@vtrubovics FYI: https://chris.beams.io/posts/git-commit/

Fixed

Hi @vtrubovics

I think you should also modify the git commit message correspondingly too.
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13203/commits

And, could you please also write some briefly description in the commit message.

Thanks.

Others are LGTM.

Amrysliu
Amrysliu approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@Amrysliu Amrysliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilyeyes
lilyeyes approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes.

jouyingbin
jouyingbin approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch. :)

@Amrysliu Amrysliu merged commit 0f4430e into os-autoinst:master Sep 9, 2021
@vtrubovics vtrubovics deleted the POO97076 branch September 9, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jouyingbin jouyingbin jouyingbin approved these changes

@Amrysliu Amrysliu Amrysliu approved these changes

@lilyeyes lilyeyes lilyeyes approved these changes

@rfan1 rfan1 rfan1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@vtrubovics @rfan1 @lilyeyes @jouyingbin @Amrysliu