Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logic for GRUB auth test on SLES UEFI mode #13206

Merged
merged 1 commit into from Sep 10, 2021
Merged

Change logic for GRUB auth test on SLES UEFI mode #13206

merged 1 commit into from Sep 10, 2021

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Sep 8, 2021

For sles platform, the grub package is not updated to the newer version as TW, so change the logic for now

@jouyingbin
Copy link
Contributor

I am a bit picky about the title. :-)
grub -> GRUB
sles -> SLES
uefi -> UEFI

But it's up to you to modify them. :)

jouyingbin
jouyingbin approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rfan1
Copy link
Contributor Author

rfan1 commented Sep 8, 2021

I am a bit picky about the title. :-)
grub -> GRUB
sles -> SLES
uefi -> UEFI

But it's up to you to modify them. :)

will do

@rfan1 rfan1 changed the title Change logic for grub auth test on sles with uefi mode Change logic for GRUB auth test on SLES UEFI mode Sep 8, 2021
Amrysliu
Amrysliu approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@Amrysliu Amrysliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilyeyes
lilyeyes approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amrysliu Amrysliu merged commit 9b8be17 into os-autoinst:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jouyingbin jouyingbin jouyingbin approved these changes

@Amrysliu Amrysliu Amrysliu approved these changes

@lilyeyes lilyeyes lilyeyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rfan1 @jouyingbin @Amrysliu @lilyeyes