Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system boot from hard disk not upgrade in grub after reboot #13238

Merged
merged 1 commit into from Sep 15, 2021

Conversation

hjluo
Copy link
Contributor

@hjluo hjluo commented Sep 13, 2021

When we reboot the system to upgrade, sometimes in grub it will timeout
and boot directly into the local disk. We need to call disable_grub_timeout
to avoid this error

https://openqa.nue.suse.com/tests/7071000
https://openqa.nue.suse.com/tests/7071001
https://openqa.nue.suse.com/tests/7087181
https://openqa.nue.suse.com/tests/7087182

@hjluo hjluo force-pushed the reboot_hdd branch 5 times, most recently from 21ce7c0 to 083a9e3 Compare September 13, 2021 03:09
@rfan1
Copy link
Contributor

rfan1 commented Sep 13, 2021

Minor comment Huajian:

Change the subject to "Stop time out in grub during update test" as well as commit mesg. but depend on you :)

} else {
reset_consoles_tty;
}
reconnect_mgmt_console if is_pvm;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't need reset console here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

power_action('reboot', textmode => 1, keepconsole => 1);
I though it will keep console, currently passed on x86, s390 and aarch64 and will check on ppc64le

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -36,10 +38,14 @@ sub run {
set_var('BOOT_HDD_IMAGE', 0) unless (is_aarch64 && !check_var('ZDUP', '1'));
}
assert_script_run "sync", 300;
enter_cmd "reboot";
power_action('reboot', textmode => 1, keepconsole => 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keep console may not work on s390x, please double check it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run a z/VM case also, https://openqa.nue.suse.com/tests/6995606

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we reboot the system to upgrade, sometimes in grub it will timeout
and boot directly into the local disk. We need to call disable_grub_timeout
to avoid this error.

For set_var('VERSION', $upgrade_target_version, reload_needles => 1);
will need some time to reload the needle.
@lemon-suse lemon-suse merged commit 346dcda into os-autoinst:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants