New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix system boot from hard disk not upgrade in grub after reboot #13238
Conversation
21ce7c0
to
083a9e3
Compare
Minor comment Huajian: Change the subject to "Stop time out in grub during update test" as well as commit mesg. but depend on you :) |
} else { | ||
reset_consoles_tty; | ||
} | ||
reconnect_mgmt_console if is_pvm; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't need reset console here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
power_action('reboot', textmode => 1, keepconsole => 1);
I though it will keep console, currently passed on x86, s390 and aarch64 and will check on ppc64le
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://openqa.nue.suse.com/tests/7097511 PASSED on ppc64le
https://openqa.nue.suse.com/tests/7088862 PASSED on ppc64le
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -36,10 +38,14 @@ sub run { | |||
set_var('BOOT_HDD_IMAGE', 0) unless (is_aarch64 && !check_var('ZDUP', '1')); | |||
} | |||
assert_script_run "sync", 300; | |||
enter_cmd "reboot"; | |||
power_action('reboot', textmode => 1, keepconsole => 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This keep console may not work on s390x, please double check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run a z/VM case also, https://openqa.nue.suse.com/tests/6995606
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we reboot the system to upgrade, sometimes in grub it will timeout and boot directly into the local disk. We need to call disable_grub_timeout to avoid this error. For set_var('VERSION', $upgrade_target_version, reload_needles => 1); will need some time to reload the needle.
When we reboot the system to upgrade, sometimes in grub it will timeout
and boot directly into the local disk. We need to call disable_grub_timeout
to avoid this error
https://openqa.nue.suse.com/tests/7071000
https://openqa.nue.suse.com/tests/7071001
https://openqa.nue.suse.com/tests/7087181
https://openqa.nue.suse.com/tests/7087182