Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Don't die if releasenotes URL is not available #13255

Closed

Conversation

rakoenig
Copy link
Contributor

@rakoenig rakoenig commented Sep 14, 2021

Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for applying in Full offline test suite, if you can just pass SCC_REGISTER', 'installation' and the test suite remains unaffected I would go for that path, if more changes are needed, then it would be to hacky and I think it is better to create additional module for that case.

tests/installation/releasenotes_origin.pm Outdated Show resolved Hide resolved
@rakoenig
Copy link
Contributor Author

I now put the code back to just record a soft failure with referencing the poo#97316 ticket. The logic if looking for RPM or URL is stll the same relying on SCC_REGISTER, just to avoid breaking existing old job definitions.

@jknphy
Copy link
Contributor

jknphy commented Sep 20, 2021

I now put the code back to just record a soft failure with referencing the poo#97316 ticket. The logic if looking for RPM or URL is stll the same relying on SCC_REGISTER, just to avoid breaking existing old job definitions.

Could you please try as well the second part of the ticket and provide a verification? 'schedule the module to offline installation test suite' to see if we need to do further changes or not.

btw, you have some extra commits from previous work (probably some missing rebase).

Zaoliang and others added 4 commits September 20, 2021 09:02
Related ticket: https://progress.opensuse.org/issues/97940
Adjust the condition to handle different tracker versions
Add a softfailure for tracker search due to bsc#1190296
Fips pattern is for SLES only, no need to install it on SLED. So
skip the installation of fips pattern for SLED.
- If we're online but still get release notes from RPM then we
  just soft-fail.
- Soft failure will have a reference to poo#97316
@rakoenig rakoenig closed this Sep 20, 2021
@rakoenig rakoenig deleted the ticket_releasenotes_origin branch September 20, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants