Replace repeating code for libyui press_next function by inheriting code from NavigationBase #13291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sofiasyria
commented
Sep 20, 2021
sofiasyria
commented
- Related ticket: https://progress.opensuse.org/issues/95745
- Verification run: http://falafel.suse.cz/tests/overview?distri=sle&version=15-SP4&build=36.1
sofiasyria
force-pushed
the
navigationbar
branch
from
082c29d
to
7d70912
Compare
sofiasyria
changed the title
jknphy
reviewed
Sep 21, 2021
There was a problem hiding this comment.
LGTM, nice replacement.
We could run just this test module in this test suite to ensure not missing anything.
lib/Installation/Partitioner/LibstorageNG/v4_3/ExpertPartitionerController.pm
Show resolved
Hide resolved
sofiasyria
force-pushed
the
navigationbar
branch
from
7d70912
to
5c2178c
Compare
sofiasyria
changed the title
sofiasyria
force-pushed
the
navigationbar
branch
from
5c2178c
to
d7f1231
Compare
sofiasyria
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.