Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance code to check NIC name #13442

Merged
merged 1 commit into from Oct 13, 2021
Merged

Enhance code to check NIC name #13442

merged 1 commit into from Oct 13, 2021

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Oct 12, 2021

Use mac address as index to find the right NIC name

@jouyingbin
Copy link
Contributor

@rfan1
There is a typo in your subject.
s/Ennhance/Enhance

@rfan1 rfan1 changed the title Ennhance code to check NIC name Enhance code to check NIC name Oct 12, 2021
@rfan1
Enhance code to check NIC name
fa70c98 
Use mac address as index to find the right NIC name
jouyingbin
jouyingbin approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilyeyes
lilyeyes approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jouyingbin
jouyingbin approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amrysliu Amrysliu merged commit ced8991 into os-autoinst:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jouyingbin jouyingbin jouyingbin approved these changes

@lilyeyes lilyeyes lilyeyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rfan1 @jouyingbin @lilyeyes @Amrysliu