Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containers: split engine class into different files #13593

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Containers: split engine class into different files #13593

merged 1 commit into from
Nov 3, 2021

Conversation

jlausuch
Copy link
Contributor

@jlausuch jlausuch commented Nov 3, 2021 •
edited
Loading

@jlausuch jlausuch requested review from b10n1k, pdostal, mloviska, asmorodskyi and grisu48 and removed request for b10n1k November 3, 2021 10:59
jlausuch
jlausuch commented Nov 3, 2021
View reviewed changes
lib/containers/basetest.pm Outdated Show resolved Hide resolved
b10n1k
b10n1k approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@b10n1k b10n1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asmorodskyi asmorodskyi merged commit 0879518 into os-autoinst:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b10n1k b10n1k b10n1k approved these changes

@pdostal pdostal Awaiting requested review from pdostal pdostal is a code owner

@mloviska mloviska Awaiting requested review from mloviska mloviska is a code owner

@asmorodskyi asmorodskyi Awaiting requested review from asmorodskyi

@grisu48 grisu48 Awaiting requested review from grisu48 grisu48 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jlausuch @b10n1k @asmorodskyi