Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install 'iputils' for CC test case ebtables_NETFILTER_PKT FAIL #13595

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

Amrysliu
Copy link
Contributor

@Amrysliu Amrysliu commented Nov 3, 2021

@lilyeyes
Copy link
Contributor

lilyeyes commented Nov 4, 2021

Could you please add more information to poo or code or PR why the fix can work?
E.g., fail_safe is failed on execution time_out another one is lack of pkgs
E.g., past the important error mesg to poo.

@lilyeyes
Copy link
Contributor

lilyeyes commented Nov 4, 2021

Any explanation to the failure on https://openqa.suse.de/tests/7594890#step/ip_eb_tables/34?

@@ -24,6 +24,9 @@ sub run {

select_console 'root-console';

# install command ping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style consistence: s/install/Install/ :)

@lilyeyes
Copy link
Contributor

lilyeyes commented Nov 4, 2021

why crypto still failed on "make -m64"?

@jouyingbin
Copy link
Contributor

jouyingbin commented Nov 4, 2021

There is a typo in your 2nd commit. ( Increase timeout when running fail_safe)

s/aviod/avoid

@Amrysliu Amrysliu force-pushed the fix_98856 branch 3 times, most recently from 6ffa161 to 697a662 Compare November 4, 2021 08:27
@Amrysliu
Copy link
Contributor Author

Amrysliu commented Nov 4, 2021

Could you please add more information to poo or code or PR why the fix can work? E.g., fail_safe is failed on execution time_out another one is lack of pkgs E.g., past the important error mesg to poo.

Added more details in the commit message.

@Amrysliu
Copy link
Contributor Author

Amrysliu commented Nov 4, 2021

why crypto still failed on "make -m64"?

I didn't rebase my branch, so it didn't include this fix. Have done it.

@Amrysliu
Copy link
Contributor Author

Amrysliu commented Nov 4, 2021

There is a typo in your 2nd commit. ( Increase timeout when running fail_safe)

s/aviod/avoid

fixed, Thanks a lot.

@Amrysliu
Copy link
Contributor Author

Amrysliu commented Nov 4, 2021

Any explanation to the failure on https://openqa.suse.de/tests/7594890#step/ip_eb_tables/34?

Here is a bug for it: https://bugzilla.suse.com/show_bug.cgi?id=1192324

Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The test case `[6] ebtables_NETFILTER_PKT` in ip_eb_tables fail because
of `test_ebtables_NETFILTER_PKT.bash: line 41: /usr/bin/ping: No such file or directory`.
So we need to install iputils. And audit-remote also needs it, so do
`zypper in` in audit_test_setup.

Related: https://progress.opensuse.org/issues/98856
The CC test case `fail_safe` sometimes will fail in 'timeout' in
aarch64, so we increase the timeout to avoid it.

Related: https://progress.opensuse.org/issues/101644
CC test case 'ip_eb_tables' tests need bridge network, when system role
is CC, the bridge network is set up automatically in x86 and arm, so we
only configure it in s390x.

Related: https://progress.opensuse.org/issues/101920
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change.

@Amrysliu Amrysliu merged commit 7e0bc4f into os-autoinst:master Nov 5, 2021
@Amrysliu Amrysliu deleted the fix_98856 branch November 5, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants