-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install 'iputils' for CC test case ebtables_NETFILTER_PKT FAIL
#13595
Conversation
Could you please add more information to poo or code or PR why the fix can work? |
Any explanation to the failure on https://openqa.suse.de/tests/7594890#step/ip_eb_tables/34? |
tests/security/cc/ip_eb_tables.pm
Outdated
@@ -24,6 +24,9 @@ sub run { | |||
|
|||
select_console 'root-console'; | |||
|
|||
# install command ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style consistence: s/install/Install/ :)
why crypto still failed on "make -m64"? |
There is a typo in your 2nd commit. ( Increase timeout when running fail_safe) s/aviod/avoid |
6ffa161
to
697a662
Compare
Added more details in the commit message. |
I didn't rebase my branch, so it didn't include this fix. Have done it. |
fixed, Thanks a lot. |
Here is a bug for it: https://bugzilla.suse.com/show_bug.cgi?id=1192324 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The test case `[6] ebtables_NETFILTER_PKT` in ip_eb_tables fail because of `test_ebtables_NETFILTER_PKT.bash: line 41: /usr/bin/ping: No such file or directory`. So we need to install iputils. And audit-remote also needs it, so do `zypper in` in audit_test_setup. Related: https://progress.opensuse.org/issues/98856
The CC test case `fail_safe` sometimes will fail in 'timeout' in aarch64, so we increase the timeout to avoid it. Related: https://progress.opensuse.org/issues/101644
CC test case 'ip_eb_tables' tests need bridge network, when system role is CC, the bridge network is set up automatically in x86 and arm, so we only configure it in s390x. Related: https://progress.opensuse.org/issues/101920
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the change.
Please see the individual commit message
Related: https://progress.opensuse.org/issues/98856, https://progress.opensuse.org/issues/101644, https://progress.opensuse.org/issues/101920
Verify run: https://openqa.suse.de/tests/7604230# (s390)
https://openqa.suse.de/tests/7604488# (aarch64)
https://openqa.suse.de/tests/7604235# (64bit)