Add check for kernel/kernel-devel version mismatch #13683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillAnastasiadis
force-pushed
the
poo_101517
branch
from
bdb013d
to
0a18612
Compare
foursixnine
reviewed
Nov 16, 2021
punkioudi
reviewed
Nov 16, 2021
|
I think we already have test for it https://openqa.suse.de/tests/7657091/modules/module_build/steps/1/src . It verifies that devel files are really for particular kernel by compilation. |
BillAnastasiadis
force-pushed
the
poo_101517
branch
from
0a18612
to
b558ff0
Compare
tjyrinki
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
I think this would be a fine addition, given that dzedro ran into the problem in the first place. It's a bit different and self-explaining approach to the test as the kernel test is assuming a compilation would fail with different version while this checks actual packages.
czerw
approved these changes
Nov 18, 2021
mdoucha
reviewed
Dec 7, 2021
| @@ -22,6 +22,17 @@ sub run { | |||
| $self->select_serial_terminal; | |||
| prepare_for_kdump(); | |||
| zypper_call("in systemtap systemtap-docs kernel-devel systemtap-server"); | |||
There was a problem hiding this comment.
Wouldn't it be better to simply specify the kernel-devel version explicitly here? That's what update_kernel module does for kernel incident tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for kernel-default-devel installation and matches it to the kernel-default installation. The appropriate message is displayed in each case, should any of those checks fail.
TEST FAILURE RUNS: (test slightly altered to fail) (15sp2)
diffrent kernel-default version: http://10.161.229.209/tests/332#step/systemtap/374
no kernel-default-devel: http://10.161.229.209/tests/333#step/systemtap/371
NORMAL RUNS:
15GA:
x86_64: https://openqa.suse.de/tests/7694449#
s390: https://openqa.suse.de/tests/7694450#
aarch64: FAILED IN PREVIOUS MODULE (mdadm) https://openqa.suse.de/tests/7694451
15sp1:
x86_64: https://openqa.suse.de/tests/7694373#
s390: https://openqa.suse.de/tests/7694429#
aarch64: https://openqa.suse.de/tests/7694448#
15sp2:
x86_64: https://openqa.suse.de/tests/7694291#
15sp3:
x86_64: https://openqa.suse.de/tests/7694290#
12sp5:
x86_64: https://openqa.suse.de/tests/7694452#
s390: https://openqa.suse.de/tests/7694453#
aarch64: https://openqa.suse.de/tests/7694454#
12sp4:
x86_64: https://openqa.suse.de/tests/7694456
s390: https://openqa.suse.de/tests/7694454#
12sp3: http://10.161.229.209/tests/309
x86_64: https://openqa.suse.de/tests/7694458#
12sp2: http://10.161.229.209/tests/310
x86_64: https://openqa.suse.de/tests/7694459#
Test is disabled on opensuse - there is another ticket to fix and enable it.