Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rpcinfo failed to show nfs on s390x #13706

Merged
merged 1 commit into from Nov 29, 2021
Merged

Conversation

hjluo
Copy link
Contributor

@hjluo hjluo commented Nov 18, 2021

On s390x, the rpcinfo command sometimes failed to show the NFS information,
so we need to try more times.

@hjluo hjluo force-pushed the rpcinfo branch 2 times, most recently from 9cc3dfd to 8ed20ab Compare November 18, 2021 03:42
lib/services/rpcbind.pm Outdated Show resolved Hide resolved
@hjluo hjluo force-pushed the rpcinfo branch 6 times, most recently from 3bf43ca to bb4524a Compare November 25, 2021 01:34
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hjluo hjluo force-pushed the rpcinfo branch 2 times, most recently from 7e0725c to 6692b02 Compare November 25, 2021 06:02
lib/services/rpcbind.pm Outdated Show resolved Hide resolved
@okurz
Copy link
Member

okurz commented Nov 25, 2021

To be correct, it would s390x, not s390X :)

@hjluo hjluo changed the title Fix rpcinfo failed to show nfs on S390X Fix rpcinfo failed to show nfs on s390x Nov 25, 2021
@hjluo
Copy link
Contributor Author

hjluo commented Nov 25, 2021

To be correct, it would s390x, not s390X :)

changed && thanks a lot

@okurz
Copy link
Member

okurz commented Nov 25, 2021

you only changed the PR description title. The important part is the git commit message which will be part of the git log

@hjluo
Copy link
Contributor Author

hjluo commented Nov 26, 2021

you only changed the PR description title. The important part is the git commit message which will be part of the git log

changed the commit message and thanks again.

On s390x, the rpcinfo command sometimes failed to show the NFS
information, so we need to try more times.
@lemon-suse lemon-suse merged commit 5878488 into os-autoinst:master Nov 29, 2021
@dzedro
Copy link
Contributor

dzedro commented Nov 29, 2021

AGAIN the extensive VRs (Verification runs) on all versions! https://openqa.suse.de/tests/7755651#step/rpcbind/70

@ostruzina
Copy link
Contributor

Hello, is there any news about fixing this? If not, would you consider reverting these changes?

These changes led to failures in all QE Maintenance job groups, thus blocking the approvals of maintenance updates.

@hjluo
Copy link
Contributor Author

hjluo commented Dec 1, 2021

Hello, is there any news about fixing this? If not, would you consider reverting these changes?

These changes led to failures in all QE Maintenance job groups, thus blocking the approvals of maintenance updates.

Hello, you can see that our changes do include t the line 'grep working /tmp/nfs/test', it just timeout, our fix finds the NFS from rpcinfo command and it works. so you can file a ticket for this
timeout issue.

Thanks.

@ostruzina
Copy link
Contributor

@hjluo You claim that your code works, yet I don't see any verification run for any of the maintenance products. A simple verification run may have shown that there is an issue. This has brought us huge headaches because the approvals of maintenance updates were completely blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants