Snapper cleanup test based on fate#312751 #1386
Conversation
| @@ -658,6 +658,7 @@ sub load_consoletests() { | |||
| } | |||
| elsif (!get_var("ZDUP") and !check_var('VERSION', '12')) { # zypper and sle12 doesn't do upgrade or installation snapshots | |||
| loadtest "console/installation_snapshots.pm"; | |||
| loadtest "console/snapper_cleanup.pm"; | |||
There was a problem hiding this comment.
what about a corresponding TW test? Please check if it works with a current TW snapshot and then add to the main.pm there
There was a problem hiding this comment.
I didn't checked it against TW, sorry. Let me check it.
|
|
Tagging as 'question' because of the open question regarding Tumbleweed Tagging as 'WIP' because I agree with Oliver that there is room for cleaner code in the snapper_cleanup.pm |
|
Last test before squash - http://crocodile.qa.suse.cz/tests/3294 |
|
opinion on what? I don't see a change in operation. I worked already perfect in before. We were just asking to squash the commits so that the two "Perltidy" become one and DRY, but no change in functionality :-) |
|
I didn't change nothing in the functionality, IMO now the code look better. |
|
👎 can't squash anymore, closing as bad experience. |
|
read git docu, you can actually recover from this situation, I am sure and I believe in you :-) You could for example call |
Test case based on fate, real example of running test:
http://crocodile.qa.suse.cz/tests/3201