Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace installation_overview with validate_default_target #13884

Merged

Conversation

OleksandrOrlov
Copy link
Contributor

@OleksandrOrlov OleksandrOrlov commented Dec 16, 2021

The installation_overview test module only validated default target in
the test suites that are edited in this commit.

The commit replaces installation_overview test module, that has a lot of
extra logic to only validate default target test module. This makes the
schedule more transparent and easy to maintain.

@OleksandrOrlov OleksandrOrlov added the WIP Work in progress label Dec 16, 2021
@OleksandrOrlov OleksandrOrlov force-pushed the replace_installation_overview branch 2 times, most recently from 38bbad3 to 50afdad Compare December 16, 2021 13:58
@OleksandrOrlov OleksandrOrlov removed the WIP Work in progress label Dec 16, 2021
Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for those minor things.
I guess we will create soon default interactive installations test suite for each flavor, where we can just run those checks once, so for now I'm not sure about adding them where there is not check, wdyt?

schedule/yast/minimal+base/minimal+base@yast.yaml Outdated Show resolved Hide resolved
schedule/yast/remote_ssh/remote_ssh_controller_sle15.yaml Outdated Show resolved Hide resolved
schedule/yast/remote_vnc/remote_vnc_controller.yaml Outdated Show resolved Hide resolved
The installation_overview test module only validated default target in
the test suites that are edited in this commit.

The commit replaces installation_overview test module, that has a lot of
extra logic to only validate default target test module. This makes the
schedule more transparent and easy to maintain.

Related ticket: https://progress.opensuse.org/issues/103362
@jknphy jknphy merged commit a153e36 into os-autoinst:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants