Handle polkit-agent-helper-1 not setuid root in CC #13894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cc setup, 'polkit-agent-helper-1' file is not setuid root by default, then it will impact our polkit tests, current workaround is "chmod u+s" for this file in our openQA test code. it is a not good way to change the default file permission to pass the test, so enhance our test code to handle it.
Amrysliu
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cc setup, 'polkit-agent-helper-1' file is not setuid root
by default, then it will impact our polkit tests, current
workaround is "chmod u+s" for this file in our openQA test code.
it is a not good way to change the default file permission to
pass the test, so enhance our test code to handle it.
BTW, the code change is done in cc test code already:
https://gitlab.suse.de/security/audit-test-sle15/-/merge_requests/44
There is no need to run the VR on aarch64 and s390x, since the change is common one and not x86_64 only