Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TrouSerS and tpm-tools to the latest version #13916

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Update TrouSerS and tpm-tools to the latest version #13916

merged 1 commit into from
Dec 24, 2021

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Dec 23, 2021 •
edited
Loading

TW tests will be next phase due to https://progress.opensuse.org/issues/103683

@jouyingbin
Copy link
Contributor

@rfan1 Looks like the CI check fail.

@lilyeyes
Copy link
Contributor

It seems automation test case does more than manual test case: https://bugzilla.suse.com/tr_show_case.cgi?case_id=1769832
I have a quesiotng: how are about other arches (s390 and ppc64le) openQA run?

@lilyeyes
Copy link
Contributor

lilyeyes commented Dec 23, 2021 •
edited
Loading

Should we rename the pm file to such as 'tpm_selftest.pm" since test case does not test tpm_tools?

@rfan1
Copy link
Contributor Author

rfan1 commented Dec 23, 2021

It seems automation test case does more than manual test case: https://bugzilla.suse.com/tr_show_case.cgi?case_id=1769832 I have a quesiotng: how are about other arches (s390 and ppc64le) openQA run?

Based jira ticket, we only need cover arm platform. at the same time, we may still have some limitation to deploy swtpm setup on s390x and ppc64le.
I will skip these 2 for now :)

@rfan1
Copy link
Contributor Author

rfan1 commented Dec 23, 2021

Should we rename the pm file to such as 'tpm_selftest.pm" since test case does not test tpm_tools?

Absolutely yes! thanks let me to

@lilyeyes
Copy link
Contributor

It seems automation test case does more than manual test case: https://bugzilla.suse.com/tr_show_case.cgi?case_id=1769832 I have a quesiotng: how are about other arches (s390 and ppc64le) openQA run?

Based jira ticket, we only need cover arm platform. at the same time, we may still have some limitation to deploy swtpm setup on s390x and ppc64le. I will skip these 2 for now :)

Got it, thanks for the explanation.

@lilyeyes
Copy link
Contributor

"schedule/security/tpm_tools.yaml" need to be renamed too.

lilyeyes
lilyeyes approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

jouyingbin
jouyingbin approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Amrysliu
Amrysliu approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@Amrysliu Amrysliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Amrysliu Amrysliu merged commit ca4573d into os-autoinst:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jouyingbin jouyingbin jouyingbin approved these changes

@Amrysliu Amrysliu Amrysliu approved these changes

@lilyeyes lilyeyes lilyeyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rfan1 @jouyingbin @lilyeyes @Amrysliu