Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test user need logout firstly #13917

Merged
merged 2 commits into from Dec 23, 2021

Conversation

lemon-suse
Copy link
Contributor

In x11, to remove a user account need logout the user firstly. So update the switch user test from 'login bernhard -> switch to test -> switch to bernhard ->logout bernhard' to 'login bernhard -> switch to test -> logout test'.

Copy link
Contributor

@chcao chcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coolgw coolgw merged commit b70cc5d into os-autoinst:master Dec 23, 2021
@GraceWang571
Copy link
Contributor

GraceWang571 commented Dec 24, 2021

So update the switch user test from 'login bernhard -> switch to test -> switch to bernhard ->logout bernhard' to 'login bernhard -> switch to test -> logout test'.

This looks weird. They are obviously not equal.
Besides, change_password failed after this PR merged. Can you please take a look? https://openqa.opensuse.org/tests/2101442#step/change_password/66

@lemon-suse
Copy link
Contributor Author

So update the switch user test from 'login bernhard -> switch to test -> switch to bernhard ->logout bernhard' to 'login bernhard -> switch to test -> logout test'.

This looks weird. They are obviously not equal. Besides, change_password failed after this PR merged. Can you please take a look? https://openqa.opensuse.org/tests/2101442#step/change_password/66

I will split this part as two, migration and desktop test, for migration need logout test after switch user, while for desktop still need to switch back to bernhard. I will file a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants