Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow vendor change for cases with packagehub and smt #14031

Merged
merged 1 commit into from Jan 18, 2022

Conversation

chcao
Copy link
Contributor

@chcao chcao commented Jan 18, 2022

When performing migration with packagehub in addon list, it would ask
whether agree to change vendor from SUSE to openSUSE for some packages,
which is reasonable because the packages from packagehub are openSUSE
packages; For smt registration type migration cases, see bsc#1120169
Comment#4, packagehub will be added to the target modules list. So we
add --allow-vendor-change for these cases.

@chcao chcao changed the title Add allow vendor change for cases with packagehub Add allow vendor change for cases with packagehub and smt Jan 18, 2022
@lemon-suse
Copy link
Contributor

I think the description need reorganize, ex: migration with packages from packagehub will ask whether agree with vendor change. Besides, we need explain the reason why need add vender change for smt test also.

Copy link
Contributor

@tinawang123 tinawang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chcao chcao force-pushed the allow_vendor_change branch 2 times, most recently from 22085fe to 9602f7d Compare January 18, 2022 08:47
@chcao
Copy link
Contributor Author

chcao commented Jan 18, 2022

I think the description need reorganize, ex: migration with packages from packagehub will ask whether agree with vendor change. Besides, we need explain the reason why need add vender change for smt test also.

OK, done, please help to review, thanks.

@lemon-suse
Copy link
Contributor

2016-2021 Please update the copyright to 2016-2022.

When performing migration with packagehub in addon list, it would ask
whether agree to change vendor from SUSE to openSUSE for some packages,
which is reasonable because the packages from packagehub are openSUSE
packages; For smt registration type migration cases, see bsc#1120169
Comment#4, packagehub will be added to the target modules list. So we
add --allow-vendor-change for these cases.
@chcao
Copy link
Contributor Author

chcao commented Jan 18, 2022

2016-2021 Please update the copyright to 2016-2022.

ok, done.

@lemon-suse lemon-suse merged commit 381c845 into os-autoinst:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants