Fix race condition in open_ssh_port #14419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknphy
changed the title
JRivrain
force-pushed
the
open_ssh_port
branch
3 times, most recently
from
4deb006
to
6128763
Compare
JRivrain
changed the title
JRivrain
changed the title
jknphy
reviewed
Mar 24, 2022
lib/Installation/InstallationSettings/InstallationSettingsPage.pm
Outdated
Show resolved
Hide resolved
JRivrain
changed the title
We verified that the port is open before it's actually opened in some cases (hyperv). Also removing pieces of code that were redundant or un-used.
JRivrain
changed the title
jknphy
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We verified that the port is open before it's actually opened in some
cases (hyperv). This fixes it.
Also now takes screenshots in overview page.
Ticket: https://progress.opensuse.org/issues/104226
VR: https://openqa.suse.de/tests/overview?build=JRivrain/os-autoinst-distri-opensuse%2314419