Fix screen share test in SLE 15-SP4 #14480

DeepthiYV · 2022-03-14T10:26:24Z

vino is considered out-of-date, and now gnome-remote-desktop progressively provides the screen sharing.
So I have renamed the test module vino_screensharing_available to screensharing_available to verify the availability of screen share across all SLE Versions. If the screen sharing is not available then test does the installation of package gnome-remote-desktop in SLE 15 SP4 and in lower version vino package.

https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/767

Related ticket:https://progress.opensuse.org/issues/104601
Needles: https://gitlab.suse.de/openqa/os-autoinst-needles-sles/-/merge_requests/1597
Verification run:
SLE 15-SP4 : http://10.161.229.147/tests/2055#step/vino_screensharing_available/1
SLE 15-SP3: https://openqa.suse.de/tests/8323509#step/vino_screensharing_available/1
SLE 15-SP1: https://openqa.suse.de/tests/8324219#step/vino_screensharing_available/1
SLE 15-SP2: https://openqa.suse.de/tests/8328802#step/vino_screensharing_available/1

Latest Verification run:
SLE 15-SP4 | SLE 15-SP3 | SLE 15-SP2 | SLE 15-SP1 | LEAP 15 aarch64 | LEAP 15 PPC64

github-actions · 2022-03-14T10:26:49Z

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files

dzedro · 2022-03-16T08:21:07Z

tests/x11/remote_desktop/vino_screensharing_available.pm

-
-        # Install the vino package which is probably the case of missing screen sharing option
-        ensure_installed 'vino';
+        if (is_sle("=15-sp4")) {


I would use 15-SP4+, I don't think on next SLE version it will go back to vino.
Applies for all is_sle

Thanks, I have updated the code to 15-SP4+.

punkioudi · 2022-03-16T09:02:51Z

Hi Dee, could you explain a bit more the purpose of the PR?
In the description you write Replaced vino to gnome-remote-desktop, but the module is called vino_screensharing_available

DeepthiYV · 2022-03-16T09:24:13Z

Hi Dee, could you explain a bit more the purpose of the PR? In the description you write Replaced vino to gnome-remote-desktop, but the module is called vino_screensharing_available

Hi Anna, I updated the description above and let me know is this ok :)

foursixnine · 2022-03-16T09:51:51Z

tests/x11/remote_desktop/vino_screensharing_available.pm

+        if (is_sle("=15-sp4")) {
+            record_info 'gnome-remote-desktop', 'After the installation the screen sharing is not available - gnome-remote-dekstop is missing and we need to install it now.';
+            send_key 'ctrl-q';
+            # Install the vino package which is probably the case of missing screen sharing option


Suggested change

# Install the vino package which is probably the case of missing screen sharing option

# Install the gnome-desktop package which is probably the case of missing screen sharing option

punkioudi · 2022-03-16T09:52:41Z

Hi Dee, could you explain a bit more the purpose of the PR? In the description you write Replaced vino to gnome-remote-desktop, but the module is called vino_screensharing_available

Hi Anna, I updated the description above and let me know is this ok :)

Still the title of the module seems misleading to me :P

punkioudi · 2022-03-16T09:54:44Z

tests/x11/remote_desktop/vino_screensharing_available.pm

+            ensure_installed 'gnome-remote-desktop';
+        }
+        else {
+            record_info 'vino missing', 'After the installation the screen sharing is not available - vino is missing and we need to install it now.';


Replace also vino here with gnome-desktop?

foursixnine · 2022-03-16T10:01:13Z

tests/x11/remote_desktop/vino_screensharing_available.pm

+            # Install the vino package which is probably the case of missing screen sharing option
+            ensure_installed 'vino';


Please add a comment on why vino is still tested, i.e (Or a link where this has been mentioned or discusse)

foursixnine · 2022-03-16T10:08:04Z

tests/x11/remote_desktop/vino_screensharing_available.pm

@@ -64,7 +69,7 @@ sub run {
        record_soft_failure 'boo#1137569 - screen sharing not yet supported on wayland';
    } else {
        assert_screen 'with_screensharing';
-        record_info 'vino present', 'Vino and the screen sharing are present';
+        is_sle("=15-sp4") ? record_info('gnome-remote-desktop present and the screen sharing are present') : record_info('vino present', 'Vino and the screen sharing are present');


see above comment from @dzedro

Updated the comment. Thanks :)

DeepthiYV · 2022-03-21T10:51:43Z

Hi Dee, could you explain a bit more the purpose of the PR? In the description you write Replaced vino to gnome-remote-desktop, but the module is called vino_screensharing_available

Hi Anna, I updated the description above and let me know is this ok :)

Sure Anna, As we discussed offline, I have renamed module to generic name and verified the test. Please let me know your feedback. Thanks :)

dzedro · 2022-03-21T11:43:32Z

lib/main_common.pm

@@ -1309,6 +1309,7 @@ sub load_x11tests {
                loadtest "x11/eog";
                loadtest(is_sle('<15') ? "x11/rhythmbox" : "x11/gnome_music");
                loadtest "x11/wireshark";
+                loadtest "x11/remote_desktop/screensharing_available" if is_sle("=15-sp4");


Why ? If difference between 15sp4+ and older versions is handled in the test.

Jozef, I scheduled screensharing_available test in we-module as gnome-remote-desktop is present SUSE Linux Enterprise Workstation Extension 15 SP4. I am still not sure how we are scheduling test. Let me know is this OK or do I need to do any changes?

I discussed with Santiago and decided to move screensharing_available test to yaml schedule. I created a new ticket https://progress.opensuse.org/issues/109373.

foursixnine · 2022-03-28T08:54:36Z

tests/x11/remote_desktop/screensharing_available.pm

-        ensure_installed 'vino';
-
+        if (is_sle("15-sp4+")) {
+            record_info 'gnome-remote-desktop', 'After the installation the screen sharing is not available - gnome-remote-dekstop is missing and we need to install it now.';


is there a bug for this? I think this should be a soft failure (same below)... I.E we should know what's the expectation and expected result after the installation?. Maybe a separate ticket to figure that out and update later (and actually use the screen sharing)... to keep things moving

There is no bug. In SLE-15 SP4, screen sharing is available by default and we do not required to install any package. I removed the code for installing the package if screen sharing is not available.

foursixnine · 2022-04-01T09:38:04Z

lib/main_common.pm

@@ -1335,6 +1335,7 @@ sub load_x11tests {
                loadtest(is_sle('<15') ? "x11/rhythmbox" : "x11/gnome_music");
                loadtest "x11/wireshark";
                loadtest "x11/ImageMagick";
+                loadtest "x11/remote_desktop/screensharing_available" if is_sle("15-sp4+");


Once you create the ticket for the extraction, please add the link to this PR

https://progress.opensuse.org/issues/109373

foursixnine · 2022-04-01T09:38:53Z

Jozef is still FTO

Use gnome-remote-desktop to share the screen in SLE 15 SP4. Renamed the test vino_screensharing_available to generic screensharing_available to test the screen share availability across all SLE flavors

DeepthiYV force-pushed the vino_screenshare_gnome branch from f095b7c to 60b5666 Compare March 14, 2022 10:47

dzedro reviewed Mar 16, 2022

View reviewed changes

foursixnine reviewed Mar 16, 2022

View reviewed changes

punkioudi reviewed Mar 16, 2022

View reviewed changes

foursixnine reviewed Mar 16, 2022

View reviewed changes

DeepthiYV force-pushed the vino_screenshare_gnome branch from 60b5666 to 3b5dd06 Compare March 20, 2022 18:28

DeepthiYV requested review from dzedro, punkioudi and foursixnine March 21, 2022 10:53

dzedro reviewed Mar 21, 2022

View reviewed changes

DeepthiYV force-pushed the vino_screenshare_gnome branch from 3b5dd06 to d0b363d Compare March 28, 2022 07:43

foursixnine reviewed Mar 28, 2022

View reviewed changes

DeepthiYV force-pushed the vino_screenshare_gnome branch 3 times, most recently from 24ae437 to 3d9e33a Compare March 30, 2022 14:49

DeepthiYV requested review from foursixnine and dzedro April 1, 2022 09:12

foursixnine approved these changes Apr 1, 2022

View reviewed changes

foursixnine reviewed Apr 1, 2022

View reviewed changes

Fix screen share test

dacf427

Use gnome-remote-desktop to share the screen in SLE 15 SP4. Renamed the test vino_screensharing_available to generic screensharing_available to test the screen share availability across all SLE flavors

DeepthiYV force-pushed the vino_screenshare_gnome branch from 3d9e33a to dacf427 Compare April 1, 2022 12:33

dzedro approved these changes Apr 5, 2022

View reviewed changes

punkioudi approved these changes Apr 5, 2022

View reviewed changes

foursixnine approved these changes Apr 12, 2022

View reviewed changes

foursixnine merged commit fc406e3 into os-autoinst:master Apr 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix screen share test in SLE 15-SP4 #14480

Fix screen share test in SLE 15-SP4 #14480

DeepthiYV commented Mar 14, 2022 •

edited

Loading

github-actions bot commented Mar 14, 2022

dzedro Mar 16, 2022 •

edited

Loading

DeepthiYV Mar 21, 2022

punkioudi commented Mar 16, 2022

DeepthiYV commented Mar 16, 2022

foursixnine Mar 16, 2022

punkioudi commented Mar 16, 2022

punkioudi Mar 16, 2022

foursixnine Mar 16, 2022

foursixnine Mar 16, 2022

DeepthiYV Mar 21, 2022

DeepthiYV commented Mar 21, 2022

dzedro Mar 21, 2022 •

edited

Loading

DeepthiYV Mar 21, 2022

DeepthiYV Apr 1, 2022

foursixnine Mar 28, 2022

DeepthiYV Mar 30, 2022 •

edited

Loading

foursixnine Apr 1, 2022

foursixnine Apr 12, 2022

foursixnine commented Apr 1, 2022

	# Install the vino package which is probably the case of missing screen sharing option
	# Install the gnome-desktop package which is probably the case of missing screen sharing option

		# Install the vino package which is probably the case of missing screen sharing option
		ensure_installed 'vino';

Fix screen share test in SLE 15-SP4 #14480

Fix screen share test in SLE 15-SP4 #14480

Conversation

DeepthiYV commented Mar 14, 2022 • edited Loading

github-actions bot commented Mar 14, 2022

dzedro Mar 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

punkioudi commented Mar 16, 2022

DeepthiYV commented Mar 16, 2022

Choose a reason for hiding this comment

punkioudi commented Mar 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeepthiYV commented Mar 21, 2022

dzedro Mar 21, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeepthiYV Mar 30, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

foursixnine commented Apr 1, 2022

DeepthiYV commented Mar 14, 2022 •

edited

Loading

dzedro Mar 16, 2022 •

edited

Loading

dzedro Mar 21, 2022 •

edited

Loading

DeepthiYV Mar 30, 2022 •

edited

Loading