WIP: Migrate some more YAML schedules using PoC for enhanced scheduler #14562
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
| @@ -58,7 +58,7 @@ test-compile-changed: os-autoinst/ | |||
|
|
|||
| .PHONY: test-yaml-valid | |||
| test-yaml-valid: | |||
| $(eval YAMLS=$(shell sh -c "git ls-files schedule/ test_data/ | grep '\\.ya\?ml$$'")) | |||
| $(eval YAMLS=$(shell sh -c "git ls-files schedule/ test_data/ | grep -v '/defaults/' | grep '\\.ya\?ml$$'")) | |||
There was a problem hiding this comment.
This is wrong in a first sight. It makes the CI obsolete and probe to give false positives
There was a problem hiding this comment.
The problem here is that the enhancement for the scheduler uses a new format for the default files which differs from the current schema used for YAML-Schedules. See my documentation on Confluence for details. So "schedule:" is no longer an array of type string, but rather a hash with sections that are arrays of string.
Therefore the YAML checking for the /defaults/ directory is omitted.
There was a problem hiding this comment.
but @b10n1k is right, in my initial PoC I just wrote that pass the CI, we will plan some ticket for it or I will improve it directly there, we need some specific path not so generic :) so no worries, was in my mind! CI/Documentation/Schema check that will come later, we are not going to merge anything with todos :)
rakoenig
force-pushed
the
poc_enh_yaml_sch
branch
from
7ab62fa
to
0fb86c2
Compare
jknphy
changed the title
jknphy
changed the title
| - installation/registration/skip_registration | ||
| extension_module_selection: | ||
| - installation/module_selection/skip_module_selection | ||
| add_on_product: |
There was a problem hiding this comment.
I would be more explicit here:
add_on_product: [] is not processed and now
add_on_product_installation:
- installation/add_on_product_installation/accept_add_on_installation
takes over, which is a different screen
for which we need a hook in default.yaml
| - console/system_prepare | ||
| - console/hostname | ||
| - console/force_scheduled_tasks | ||
| - shutdown/grub_set_bootargs |
There was a problem hiding this comment.
this test module we could unschedule it, it is not needed.
| system_preparation: | ||
| - console/system_prepare | ||
| - console/hostname | ||
| - console/force_scheduled_tasks |
There was a problem hiding this comment.
only the threes tests above are considered preparation, the rest is system_validation.
| default_systemd_target: | ||
| - installation/installation_settings/validate_default_target | ||
| grub: | ||
| - installation/grub_test |
There was a problem hiding this comment.
not needed, handle_reboot will do the job, but we should find in the future some way to make it more readable, as there is not reconnection or any remote in this case for example, but afir there was some controversy with the name in PR creating that test module and got that handle_reboot instead of handle_grub, I would say let's use the default here for now.
|
Not to be merged in any way. |
This is just a PoC, do not merge!
Few more tests migrated to the enhanced scheduler.
Diversion in USBInstall (Full medium or Online Medium) is resovled by creating a default for Full medium.