Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New test procedure for TigerVNC version >= 1.12 #14626

Merged
merged 1 commit into from Apr 1, 2022
Merged

New test procedure for TigerVNC version >= 1.12 #14626

merged 1 commit into from Apr 1, 2022

Conversation

pablo-herranz
Copy link
Contributor

@pablo-herranz pablo-herranz commented Apr 1, 2022 •
edited

According to this tutorial, the tests for TigerVNC versions greater than or equal to 1.12.0 must be redefined.

@pablo-herranz
New test procedure for TigerVNC version >=1.12
b751777 
Add missing ; at line 165, 171 and run Tidy

Add 'package_version_cmp' library

Fix TigerVNC version comparison

Add version compare also for shutting down vncserver

Change key strokes for popups in the new version

Change the command for getting the version

Change the command for getting the version, this time ok
@foursixnine
Copy link
Member

@pablo-herranz can you schedule couple of runs? something like 10 for o3 and for openSUSE?

@pablo-herranz
Copy link
Contributor Author

pablo-herranz commented Apr 1, 2022 •
edited

@pablo-herranz can you schedule couple of runs? something like 10 for o3 and for openSUSE?

Done, they're running now. (link in description :) )

@DimStar77
Copy link
Contributor

@pablo-herranz can you schedule couple of runs? something like 10 for o3 and for openSUSE?

Done, they're running now. (link in description :) )

Have the SLE tests been flaky before? SLE15 SP4 lists two failures

@pablo-herranz
Copy link
Contributor Author

@pablo-herranz can you schedule couple of runs? something like 10 for o3 and for openSUSE?

Done, they're running now. (link in description :) )

Have the SLE tests been flaky before? SLE15 SP4 lists two failures

Looks like they're failing in a step non-related with my code. Anyway, I'll schedule some more without my changes and see.

@pablo-herranz
Copy link
Contributor Author

Runs without changes here --> https://openqa.suse.de/tests/overview?distri=sle&version=15-SP4&build=poo107320_investigation_sle15sp4_nochanges

@pablo-herranz
Copy link
Contributor Author

@pablo-herranz can you schedule couple of runs? something like 10 for o3 and for openSUSE?

Done, they're running now. (link in description :) )

Have the SLE tests been flaky before? SLE15 SP4 lists two failures

Yup, looks like it was failing before my changes --> https://openqa.suse.de/tests/8455880#step/vnc_two_passwords/33
I've scheduled another 25 to see what happens.

@DimStar77 DimStar77 merged commit 6a47fa8 into os-autoinst:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimStar77 DimStar77 DimStar77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pablo-herranz @foursixnine @DimStar77