Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making transactional_update module fatal #14630

Merged
merged 1 commit into from Apr 1, 2022

Conversation

Avinesh
Copy link
Contributor

@Avinesh Avinesh commented Apr 1, 2022

Missing curl package in sle15.4 transactional server role turned out to be a product bug which is being fixed
(https://bugzilla.suse.com/show_bug.cgi?id=1197913)

As part of this commit, I am making the transactional_update module fatal, so no further related test are run unnecessarily.

@foursixnine foursixnine merged commit 4effcbe into os-autoinst:master Apr 1, 2022
@Avinesh Avinesh deleted the transactional-update branch April 1, 2022 15:38
@jlausuch
Copy link
Contributor

jlausuch commented Apr 2, 2022

I accidentaly delete my previous comment. I was saying that I would like to revert this PR. This module is used in multiple places in SLE Micro and MicroOS and executing the rest of the tests if this fails is still valid.
@Vogtinator

@Avinesh
Copy link
Contributor Author

Avinesh commented Apr 4, 2022

Okay, in that case I am reverting this commit. I will discuss with @foursixnine if we need to handle it some other way.

@Vogtinator
Copy link
Member

fatal => 1, no_rollback => 1 is a weird combination anyway, it doesn't really make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants