Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate 'DBus services exposure' of Atsec into openQA #14669

Merged
merged 2 commits into from Apr 24, 2022
Merged

Integrate 'DBus services exposure' of Atsec into openQA #14669

merged 2 commits into from Apr 24, 2022

Conversation

Amrysliu
Copy link
Contributor

@Amrysliu Amrysliu commented Apr 7, 2022 •
edited

@Amrysliu Amrysliu marked this pull request as draft April 7, 2022 01:14
@Amrysliu Amrysliu force-pushed the integrate_dbus_services_exposure branch 8 times, most recently from 8e45e13 to 005649b Compare April 7, 2022 12:04
@Amrysliu Amrysliu marked this pull request as ready for review April 7, 2022 12:11
@Amrysliu Amrysliu marked this pull request as draft April 14, 2022 08:28
@Amrysliu Amrysliu force-pushed the integrate_dbus_services_exposure branch from 005649b to c2ecda5 Compare April 14, 2022 12:20
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files

@Amrysliu Amrysliu force-pushed the integrate_dbus_services_exposure branch from c2ecda5 to 3aa81bd Compare April 14, 2022 12:34
@Amrysliu Amrysliu force-pushed the integrate_dbus_services_exposure branch 9 times, most recently from 162b216 to 85596f3 Compare April 19, 2022 09:11
@Amrysliu Amrysliu marked this pull request as ready for review April 19, 2022 09:42
rfan1
rfan1 approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilyeyes
lilyeyes reviewed Apr 21, 2022
View reviewed changes
lib/atsec_test.pm Outdated Show resolved Hide resolved
@Amrysliu Amrysliu force-pushed the integrate_dbus_services_exposure branch from 85596f3 to d185f85 Compare April 21, 2022 02:34
@lilyeyes
Copy link
Contributor

lilyeyes commented Apr 21, 2022 •
edited

For case "4.3 DBus fuzzer" in confluence page it says "This list is incorporated in dfuzz.sh file which is to be executed."
This dfuzz.sh does not be found in you code, do you have any replacement code for it?

Or, just guess, dfuzz.sh might be wrapped by dfuzzer.

Generally look good to me.

@Amrysliu
Copy link
Contributor Author

Amrysliu commented Apr 21, 2022 •
edited

@lilyeyes
No, I didn't find this script. From the logs message, I think dfuzz.sh is used to testing every dbus name by running ./dfuzzer -v -n xxxx and generate the log files. I did that in my test code, so I guess we don't need dfuzz.sh

@lilyeyes
Copy link
Contributor

@lilyeyes No, I didn't find this script. From the logs message, I think dfuzz.sh is used to testing every dbus name by running ./dfuzzer -v -n xxxx and generate the log files. I did that in my test code, so I guess we don't need dfuzz.sh

Thanks.

lilyeyes
lilyeyes approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revise and explanation, LGTM now.

@Amrysliu Amrysliu merged commit adcb00c into os-autoinst:master Apr 24, 2022
This was referenced May 5, 2022
Open
Closed
evverx
evverx reviewed May 7, 2022
View reviewed changes
tests/security/atsec/dbus_fuzzer.pm

# Compile
assert_script_run("cd $atsec_test::code_dir/pentest/dfuzzer-master/src");
assert_script_run('make');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dfuzzer kind of switched to meson in https://github.com/matusmarhefka/dfuzzer/pull/26 and can be built and run with

meson --buildtype=release build
ninja -C ./build
./build/dfuzzer ...

Makefile will be removed once the dfuzzer package switches to meson as well. Also it no longer depends on libffi-devel.

evverx
evverx reviewed May 7, 2022
View reviewed changes
tests/security/atsec/dbus_fuzzer.pm

# Compile
assert_script_run("cd $atsec_test::code_dir/pentest/dfuzzer-master/src");
assert_script_run('make');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dfuzzer kind of switched to meson in https://github.com/matusmarhefka/dfuzzer/pull/26 and can be built and run with

meson --buildtype=release build
ninja -C ./build
./build/dfuzzer ...

Makefile will be removed once the dfuzzer package switches to meson as well. Also it no longer depends on libffi-devel.

evverx
evverx reviewed May 7, 2022
View reviewed changes
tests/security/atsec/dbus_fuzzer.pm
assert_script_run("cd $atsec_test::code_dir/pentest/dfuzzer-master/src");
assert_script_run('make');

my $output = script_output('./dfuzzer -l 2>&1');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of dfuzzer -l changed recently and I suspect it broke the script. I opened https://github.com/matusmarhefka/dfuzzer/issues/67 to figure out what can be done to make it easier to use it in scripts like this.

@evverx evverx mentioned this pull request May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evverx evverx evverx left review comments

@lilyeyes lilyeyes lilyeyes approved these changes

@rfan1 rfan1 rfan1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Amrysliu @lilyeyes @evverx @rfan1