Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update needle tag name in x3270_ssl #14679

Merged
merged 1 commit into from Apr 11, 2022
Merged

Update needle tag name in x3270_ssl #14679

merged 1 commit into from Apr 11, 2022

Conversation

STARRY-S
Copy link
Contributor

@STARRY-S STARRY-S commented Apr 8, 2022 •
edited

Change the needle tag name in x3270_ssl from generic-desktop to x3270_ssl_desktop.

@STARRY-S STARRY-S marked this pull request as draft April 8, 2022 07:48
@STARRY-S STARRY-S changed the title [WIP]Update needle tag name in x3270_ssl Update needle tag name in x3270_ssl Apr 8, 2022
@STARRY-S STARRY-S marked this pull request as ready for review April 8, 2022 09:06
@rfan1
Copy link
Contributor

rfan1 commented Apr 8, 2022

  • Change needle name generic-desktop to x3270_ssl_desktop.

I suggest you add more comments why we change the name :), others LGTM

@STARRY-S
Update needle tag name in x3270_ssl
076f9f1 
- Changed the needle name `generic-desktop` to `x3270_ssl_desktop`
  since there are still have "xterm" and "x3270" windows here.
@STARRY-S
Copy link
Contributor Author

STARRY-S commented Apr 8, 2022

  • Change needle name generic-desktop to x3270_ssl_desktop.

I suggest you add more comments why we change the name :), others LGTM

Sure, thanks for your comments, and I've updated it.

rfan1
rfan1 approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jouyingbin
jouyingbin approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

lilyeyes
lilyeyes approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amrysliu Amrysliu merged commit 74cac7c into os-autoinst:master Apr 11, 2022
@STARRY-S STARRY-S deleted the update_x3270_ssl branch April 11, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jouyingbin jouyingbin jouyingbin approved these changes

@lilyeyes lilyeyes lilyeyes approved these changes

@rfan1 rfan1 rfan1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@STARRY-S @rfan1 @jouyingbin @lilyeyes @Amrysliu