Activate python2 as workaround on SLE15-SP1+ #14790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
lemon-suse
force-pushed
the
fix_python2_active_on_sle12
branch
from
65ce9a5
to
571cc34
Compare
coolgw
approved these changes
Apr 27, 2022
hjluo
approved these changes
Apr 27, 2022
lib/registration.pm
Outdated
| @@ -867,7 +867,7 @@ sub scc_deregistration { | |||
| quit_packagekit; | |||
| wait_for_purge_kernels; | |||
| assert_script_run('SUSEConnect --version'); | |||
| if (get_var('UPGRADE_TARGET_VERSION') == '15-SP3') { | |||
| if ((check_var('UPGRADE_TARGET_VERSION', '15-SP3')) && (is_sle('15+'))) { | |||
|
Please run a case from SLES15GA in continuous group. On SLES15GA, python2 module is not available too. So maybe need to change (is_sle('15+') -> (is_sle('15.1+')? |
Update condition for workaround for bsc#1189543 to make sure on SLE15-SP1+.
lemon-suse
force-pushed
the
fix_python2_active_on_sle12
branch
from
571cc34
to
3496378
Compare
lemon-suse
changed the title
Yes, I think so. I have updated the code and VRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update condition for workaround for bsc#1189543 to make sure on SLE15-SP1+.
http://openqa.nue.suse.com/tests/8644254# HA case
http://openqa.nue.suse.com/tests/8644255#step/patch_sle/103 12SP4
http://openqa.nue.suse.com/tests/8644259#details 15SP1
http://openqa.nue.suse.com/tests/8644387# Continuous migration SLE15GA ->15SP2, no activate python2, pass
https://openqa.nue.suse.com/tests/8644416#step/scc_deregistration/11 Continuous migration SLE15SP1->15SP3, activate python2, pass