Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate test case: eCryptfs #14792

Merged
merged 1 commit into from Jun 13, 2022
Merged

Integrate test case: eCryptfs #14792

merged 1 commit into from Jun 13, 2022

Conversation

STARRY-S
Copy link
Contributor

@STARRY-S STARRY-S commented Apr 27, 2022

Integrate the eCryptfs test case.

@STARRY-S STARRY-S changed the title Integrate test case: eCryptfs [WIP]Integrate test case: eCryptfs Apr 27, 2022
@lilyeyes
Copy link
Contributor

Please keep the coding style, such as keep using func() or only using func ''

@STARRY-S
Copy link
Contributor Author

Please keep the coding style, such as keep using func() or only using func ''

Done, thanks.

@lilyeyes
Copy link
Contributor

Generally looks good to me.
Btw, one question. should we test "md5" here since the "testing step" in confluence page mentioned "md5"?

@STARRY-S
Copy link
Contributor Author

STARRY-S commented Apr 28, 2022

Generally looks good to me. Btw, one question. should we test "md5" here since the "testing step" in confluence page mentioned "md5"?

Hi Lili,
When executing the mount command, it only shows the following encrypt methods:

# mount -t ecryptfs -o key=passphrase:passphrase_passwd=passwd ./.private ./private
Select cipher: 
 1) aes: blocksize = 16; min keysize = 16; max keysize = 32
 2) blowfish: blocksize = 8; min keysize = 16; max keysize = 56
 3) des3_ede: blocksize = 8; min keysize = 24; max keysize = 24
 4) twofish: blocksize = 16; min keysize = 16; max keysize = 32
 5) cast6: blocksize = 16; min keysize = 16; max keysize = 32
 6) cast5: blocksize = 8; min keysize = 5; max keysize = 16
Selection [aes]: 

Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tests/security/ecryptfs/ecryptfs.pm Show resolved Hide resolved
@jouyingbin
Copy link
Contributor

SLE 15 SP4 VR:

x86_64:
ker_mode: https://openqa.suse.de/tests/8930859
env_mode: https://openqa.suse.de/tests/8930860

@STARRY-S
Copy link
Contributor Author

SLE 15 SP4 VR:

x86_64: ker_mode: https://openqa.suse.de/tests/8930859 env_mode: https://openqa.suse.de/tests/8930860

Thanks.

@STARRY-S STARRY-S changed the title [WIP]Integrate test case: eCryptfs Integrate test case: eCryptfs Jun 10, 2022
@jouyingbin
Copy link
Contributor

Provide the SLE 15 SP4 VR and all of them are passed after discussing and refining the code again by Starry:

x86_64:
ker_mode: https://openqa.suse.de/tests/8930859
env_mode: https://openqa.suse.de/tests/8930860

s390x:
ker_mode: https://openqa.suse.de/tests/8930920
env_mode: https://openqa.suse.de/tests/8930919

aarch64:
ker_mode: https://openqa.suse.de/tests/8930918
env_mode: https://openqa.suse.de/tests/8930917

Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job.

Integrated the ecryptfs test case.
Copy link
Contributor

@RoyCai7 RoyCai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amrysliu Amrysliu merged commit 9388fd7 into os-autoinst:master Jun 13, 2022
@STARRY-S STARRY-S deleted the new_ecryptfs branch June 13, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants