Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate test case: libserf #14808

Merged
merged 1 commit into from Jun 13, 2022
Merged

Integrate test case: libserf #14808

merged 1 commit into from Jun 13, 2022

Conversation

STARRY-S
Copy link
Contributor

@STARRY-S STARRY-S commented Apr 29, 2022 •
edited

Integrate the libserf test case into openQA.

RoyCai7
RoyCai7 approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@RoyCai7 RoyCai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.
Clear logic.

@jouyingbin
Copy link
Contributor

@STARRY-S Generally looks great to me.
A question is the test result in Leap15.4 and SLE15 SP4 are the same, right?

@STARRY-S
Copy link
Contributor Author

STARRY-S commented May 5, 2022

@STARRY-S Generally looks great to me. A question is the test result in Leap15.4 and SLE15 SP4 are the same, right?

Hi Ben!
The manual test result on Leap 15.4 and SLE15 SP4 are same.

@jouyingbin
Copy link
Contributor

SLE 15 SP4 VR:

x86_64:
ker_mode: https://openqa.suse.de/tests/8930858
env_mode: https://openqa.suse.de/tests/8930857

@jouyingbin
Copy link
Contributor

Provide the SLE 15 SP4 VR and all of them are passed after discussing and refining the code again by Starry:

x86_64:
ker_mode: https://openqa.suse.de/tests/8930858
env_mode: https://openqa.suse.de/tests/8930857

s390x:
ker_mode: https://openqa.suse.de/tests/8930923
env_mode: https://openqa.suse.de/tests/8930924

aarch64:
ker_mode: https://openqa.suse.de/tests/8930921
env_mode: https://openqa.suse.de/tests/8930922

@STARRY-S STARRY-S changed the title [WIP]Integrate test case: libserf Integrate test case: libserf Jun 10, 2022
@STARRY-S
Copy link
Contributor Author

Provide the SLE 15 SP4 VR and all of them are passed after discussing and refining the code again by Starry:

Thanks.

@STARRY-S
Integrate test case: libserf
b543d64 
Integrate the `libserf` test case into openQA.
rfan1
rfan1 approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jouyingbin
jouyingbin approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job.

@Amrysliu Amrysliu merged commit c8fceca into os-autoinst:master Jun 13, 2022
@STARRY-S STARRY-S deleted the new_libserf branch June 13, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyCai7 RoyCai7 RoyCai7 approved these changes

@jouyingbin jouyingbin jouyingbin approved these changes

@rfan1 rfan1 rfan1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@STARRY-S @jouyingbin @RoyCai7 @rfan1 @Amrysliu