JeOS: expand image information #14873
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
|
tests/jeos/image_info.pm
Outdated
| record_info('GlobalReserve', "$globalreserve_mb MB"); | ||
|
|
||
| # Get size of the root directories in KB (except /proc). | ||
| my $dirs = script_output('du -d 1 --block-size=1K --exclude=/proc /'); |
There was a problem hiding this comment.
IMO not that useful, except maybe /usr and /var
There was a problem hiding this comment.
Yeah, but as I'm running that in some loop way for all dirs, we can always chose to represent which data to display in the Graphs. Otherwise I would need to create a list of directories to analyze which may vary in the future. This way we just collect data for all directories under / and later one we show what we want.
There was a problem hiding this comment.
You already exclude /proc and you'd have to exclude some others anyway as the sizes are nonsensical (/sys, /dev/, /.snapshots)...
There was a problem hiding this comment.
Would you prefer to collect only /usr and /var or do:
du -d 1 --block-size=1K --exclude=/proc --exclude=/sys --exclude=/dev /
?
Actually /.snapshots is not empty when running this module (maybe due to firstboot)
There was a problem hiding this comment.
IMO just mentioning those two is simpler. Actually, there's also /tmp, unlike on TW that's not a tmpfs yet.
/.snapshots doesn't show up as empty, but the returned size is useless as it's backed by btrfs magic 🌈
There was a problem hiding this comment.
ok, will get the info of those 2 dirs then, thanks for the feedback!
There was a problem hiding this comment.
Actually, I also forgot about usr-merge only being in TW... For SLE we'd need /(s)bin and /lib(64) as well. I also forgot about /boot... So excluding "special" mounts is probably the best idea.
There was a problem hiding this comment.
ok, moving back to my original idea :D
jlausuch
force-pushed
the
jeos_image_info
branch
4 times, most recently
from
6e7a041
to
bc121e1
Compare
|
All suggestions have been addressed. |
jlausuch
force-pushed
the
jeos_image_info
branch
2 times, most recently
from
2606f0d
to
8550f9c
Compare
|
Anyway, I'm gonna work on a small modification. |
jlausuch
force-pushed
the
jeos_image_info
branch
2 times, most recently
from
753b85f
to
be6793d
Compare
|
With latest changes: https://openqa.opensuse.org/tests/2345457# |
|
@Vogtinator @mloviska any more feedback on this? |
jlausuch
force-pushed
the
jeos_image_info
branch
2 times, most recently
from
45dae97
to
f6e1a74
Compare
|
This PR breaks tests on RPi 2/3/4 on O3: https://progress.opensuse.org/issues/111362 |
Related tickets:
VR: https://openqa.opensuse.org/tests/2338516