Create test module: Vsftpd #14909
Merged
Create test module: Vsftpd #14909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing vsftpd and lftp with ssl enabled
rfan1
reviewed
May 17, 2022
tests/security/vsftpd/lftp.pm
Outdated
| assert_script_run('ls | grep f1.txt'); | ||
|
|
||
| # Upload a file to directory | ||
| assert_script_run('touch f2.txt'); |
There was a problem hiding this comment.
I suggest you add some context to f1.txt and f2.txt,
and if possible, md5 check for both file should be better
rfan1
reviewed
May 17, 2022
| assert_script_run("mkdir -p $ftp_file_path"); | ||
| assert_script_run("chown $user:users $ftp_file_path"); | ||
|
|
||
| # New user needs access to ttyS0 |
There was a problem hiding this comment.
Good change, l suggest you add more comment for the default permission 620, then we need change it
rfan1
reviewed
May 17, 2022
tests/security/vsftpd/vsftpd.pm
Outdated
|
|
||
| select_console 'root-console'; | ||
|
|
||
| # Create a file |
Amrysliu
reviewed
May 18, 2022
tests/security/vsftpd/lftp.pm
Outdated
| enter_cmd('cd files/'); | ||
| enter_cmd('ls'); | ||
| enter_cmd('put f2.txt'); | ||
| enter_cmd('exit'); |
There was a problem hiding this comment.
These codes could be written in a for loop to avoid repeating?
jouyingbin
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing vsftpd and lftp with ssl enabled. There are bugs related to this test module currently. Thus further code enhancement is anticipated when bugs are fixed or discovered acceptable workarounds. Test verification is expected to fail due to those bugs. And testing mechanisms can be enhanced once bugs are fixed.