Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a uefi qcow image used by security tests #14930

Merged
merged 1 commit into from May 31, 2022
Merged

Generate a uefi qcow image used by security tests #14930

merged 1 commit into from May 31, 2022

Conversation

Amrysliu
Copy link
Contributor

@Amrysliu Amrysliu commented May 19, 2022 •
edited

Our CC and FIPS tests should cover UEFI secure boot mode, so need to
generate a qcow file for these tests.

Related: https://progress.opensuse.org/issues/111389
Verify run: https://openqa.suse.de/tests/8830704#
https://openqa.suse.de/tests/8830743# (The job run base on the qcow2 published by the above job)

@Amrysliu Amrysliu marked this pull request as draft May 19, 2022 07:51
@Amrysliu Amrysliu force-pushed the create_yastfile branch 2 times, most recently from 16e37ed to 1aea329 Compare May 20, 2022 09:28
@Amrysliu Amrysliu marked this pull request as ready for review May 20, 2022 10:52
rfan1
rfan1 approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfan1
Copy link
Contributor

rfan1 commented May 23, 2022 •
edited

Let us wait for experts' comments from yast team before merging this PR

@rfan1
Copy link
Contributor

rfan1 commented May 23, 2022

@Amrysliu
BTW, Can we use the same yaml_schedule file as existing ones?

rfan1
rfan1 reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if we can use the existing yaml_schedule file

@Amrysliu
Copy link
Contributor Author

Please check if we can use the existing yaml_schedule file

yes, I think Roy and I could use one yaml file.

@jknphy
Copy link
Contributor

jknphy commented May 24, 2022

check comments from #14938
and I would suggest to ensure with verification that children job run properly (AutoYaST also might have some bugs :) )

@Amrysliu
Generate a textmode uefi qcow image for security tests
19f2f4c 
Our CC and Fips tests should coverage UEFI secure boot mode, so need to
generate a qcow file for these tests.

Related: https://progress.opensuse.org/issues/111389
RoyCai7
RoyCai7 approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@RoyCai7 RoyCai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jknphy
Copy link
Contributor

jknphy commented May 27, 2022

LGTM

@Amrysliu Amrysliu merged commit 925dee2 into os-autoinst:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfan1 rfan1 rfan1 approved these changes

@RoyCai7 RoyCai7 RoyCai7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Amrysliu @rfan1 @jknphy @RoyCai7