Fix the issue about imcomplete input on powershell #15010

RoyCai7 · 2022-06-02T09:49:05Z

Imcomplete input on powershell
POO: https://progress.opensuse.org/issues/109091

Related ticket: https://progress.opensuse.org/issues/109091
Needles: NA
Verification run: https://openqa.suse.de/tests/8864107

rfan1 · 2022-06-02T10:24:15Z

tests/x11/remote_desktop/windows_network_setup.pm

@@ -32,6 +32,7 @@ sub run {
    $self->run_in_powershell(cmd => 'Get-NetIPAddress -InterfaceAlias $a.name', tags => 'win-remote-desktop');
    $self->run_in_powershell(cmd => 'New-NetIPAddress -InterfaceAlias $a.name -IPAddress 10.0.2.18 -PrefixLength 24 -DefaultGateway 10.0.2.2 -Confirm:$false', tags => 'win-remote-desktop');
    approve_network_popup;
+    sleep 3;


wait_still_screen 3;

sleep 3 is passed.

I try to use wait_still_screen

rfan1 · 2022-06-06T01:35:14Z

tests/x11/remote_desktop/windows_network_setup.pm

@@ -32,6 +32,7 @@ sub run {
    $self->run_in_powershell(cmd => 'Get-NetIPAddress -InterfaceAlias $a.name', tags => 'win-remote-desktop');
    $self->run_in_powershell(cmd => 'New-NetIPAddress -InterfaceAlias $a.name -IPAddress 10.0.2.18 -PrefixLength 24 -DefaultGateway 10.0.2.2 -Confirm:$false', tags => 'win-remote-desktop');
    approve_network_popup;
+    wait_still_screen 3;


LGTM， could you please add some comments here why you add 'sleep‘ here？

Add some comments and tags.

rfan1 · 2022-06-06T03:09:49Z

tests/x11/remote_desktop/windows_network_setup.pm

+    # Imcomplete input on powershell because executing command is too fast
+    # Poo#109091


Suggest change:
We may miss some characters due to type command too fast after network popup, so wait several seconds as a workaround,
See poo#109091

Imcomplete input on powershell POO: https://progress.opensuse.org/issues/109091

rfan1

LGTM

rfan1 · 2022-06-06T03:14:32Z

@GraceWang571
Could you please help review this PR?

GraceWang571

I see many test cases invoke run_in_powershell, I'd like to say add wait_still_screen in run_in_powershell would be a better choice.
You know there might be similar failure when invoking run_in_powershell without wait_still_screen before OR in it.

jouyingbin · 2022-06-06T06:20:22Z

@Wangqianzou there is typo in your subject and git commit message.

typo: imcomplete - > incomplete

rfan1 · 2022-06-06T06:21:13Z

I see many test cases invoke run_in_powershell, I'd like to say add wait_still_screen in run_in_powershell would be a better choice. You know there might be similar failure when invoking run_in_powershell without wait_still_screen before OR in it.

Actually, I talked with Roy last week, and I had the same suggestion, however, for this single case, the issue was not related to powershell script, since the issue seems happen after:

sub approve_network_popup {
# if there is the networks popup that ask's if it's ok to be discoverable, approve it
wait_still_screen stilltime => 5, timeout => 10;
assert_screen([qw(networks-popup-be-discoverable no-network-discover-popup)], 60);
if (match_has_tag 'networks-popup-be-discoverable') {
assert_and_click 'network-discover-yes';
wait_screen_change(sub { send_key 'ret' }, 10);
}
}

rfan1 · 2022-06-06T06:25:02Z

I see many test cases invoke run_in_powershell, I'd like to say add wait_still_screen in run_in_powershell would be a better choice. You know there might be similar failure when invoking run_in_powershell without wait_still_screen before OR in it.

Actually, I talked with Roy last week, and I had the same suggestion, however, for this single case, the issue was not related to powershell script, since the issue seems happen after:

sub approve_network_popup { # if there is the networks popup that ask's if it's ok to be discoverable, approve it wait_still_screen stilltime => 5, timeout => 10; assert_screen([qw(networks-popup-be-discoverable no-network-discover-popup)], 60); if (match_has_tag 'networks-popup-be-discoverable') { assert_and_click 'network-discover-yes'; wait_screen_change(sub { send_key 'ret' }, 10); } }

BTW， add wait_still_screen to un_in_powershell may consume more time :)

GraceWang571 · 2022-06-06T08:16:09Z

Actually, I talked with Roy last week, and I had the same suggestion, however, for this single case, the issue was not related to powershell script, since the issue seems happen after:

sub approve_network_popup { # if there is the networks popup that ask's if it's ok to be discoverable, approve it wait_still_screen stilltime => 5, timeout => 10; assert_screen([qw(networks-popup-be-discoverable no-network-discover-popup)], 60); if (match_has_tag 'networks-popup-be-discoverable') { assert_and_click 'network-discover-yes'; wait_screen_change(sub { send_key 'ret' }, 10); } }

I am afraid I can't agree with you. As you can see the approve_network_popup; was invoked twice in windows_network_setup.pm. And Roy only made changes for one of them and then the test case passed.

As you might know, poo#109091 is a performance issue and can't be reproduced 100%. Our goal is to make the test code robust to avoid the failures caused by the possible performance.

rfan1 · 2022-06-06T11:07:05Z

@Wangqianzou
As offline discussion with @GraceWang571,

I would suggest you add the workaround into function approve_network_popup. since We use this function more than once!

And if you have seen any performance issue with run_in_powershell, you may add the similiar workaround as well to this function. [as far as I know, we rarely hit that issue before :)]

rfan1 · 2022-06-07T03:21:30Z

#15017

@Wangqianzou You can close this PR once you back from vacation.

rfan1 reviewed Jun 2, 2022

View reviewed changes

RoyCai7 force-pushed the windows_network_setup_109091 branch from 2669594 to 7e8f4b3 Compare June 2, 2022 10:41

RoyCai7 mentioned this pull request Jun 6, 2022

Fix erratic behavior of windows network setup #14200

Merged

RoyCai7 marked this pull request as ready for review June 6, 2022 01:02

rfan1 reviewed Jun 6, 2022

View reviewed changes

RoyCai7 force-pushed the windows_network_setup_109091 branch from 7e8f4b3 to 5c9ed02 Compare June 6, 2022 02:52

rfan1 reviewed Jun 6, 2022

View reviewed changes

Fix the issue about imcomplete input on powershell

c5a7d52

Imcomplete input on powershell POO: https://progress.opensuse.org/issues/109091

RoyCai7 force-pushed the windows_network_setup_109091 branch from 5c9ed02 to c5a7d52 Compare June 6, 2022 03:12

rfan1 approved these changes Jun 6, 2022

View reviewed changes

GraceWang571 requested changes Jun 6, 2022

View reviewed changes

RoyCai7 closed this Jun 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the issue about imcomplete input on powershell #15010

Fix the issue about imcomplete input on powershell #15010

RoyCai7 commented Jun 2, 2022 •

edited

rfan1 Jun 2, 2022

RoyCai7 Jun 2, 2022

RoyCai7 Jun 2, 2022

rfan1 Jun 6, 2022

RoyCai7 Jun 6, 2022

RoyCai7 Jun 6, 2022

rfan1 Jun 6, 2022

RoyCai7 Jun 6, 2022

rfan1 left a comment

rfan1 commented Jun 6, 2022

GraceWang571 left a comment •

edited

jouyingbin commented Jun 6, 2022

rfan1 commented Jun 6, 2022

rfan1 commented Jun 6, 2022

GraceWang571 commented Jun 6, 2022

rfan1 commented Jun 6, 2022

rfan1 commented Jun 7, 2022

		# Imcomplete input on powershell because executing command is too fast
		# Poo#109091

Fix the issue about imcomplete input on powershell #15010

Fix the issue about imcomplete input on powershell #15010

Conversation

RoyCai7 commented Jun 2, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfan1 left a comment

Choose a reason for hiding this comment

rfan1 commented Jun 6, 2022

GraceWang571 left a comment • edited

Choose a reason for hiding this comment

jouyingbin commented Jun 6, 2022

rfan1 commented Jun 6, 2022

rfan1 commented Jun 6, 2022

GraceWang571 commented Jun 6, 2022

rfan1 commented Jun 6, 2022

rfan1 commented Jun 7, 2022

RoyCai7 commented Jun 2, 2022 •

edited

GraceWang571 left a comment •

edited