Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to mitigate key repetition errors in X sessions #15095

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Try to mitigate key repetition errors in X sessions #15095

merged 2 commits into from
Jun 30, 2022

Conversation

okurz
Copy link
Member

@okurz okurz commented Jun 15, 2022 •
edited
Loading

  • Add 'x11/setup' with disabled key repetition to schedules
  • Try to mitigate "VNC typing issues" with disabled key repeat

Verification runs:

for i in https://openqa.opensuse.org/tests/2415152 https://openqa.opensuse.org/tests/2414998 https://openqa.opensuse.org/tests/2415293 https://openqa.opensuse.org/tests/2414950 https://openqa.opensuse.org/tests/2415061 https://openqa.opensuse.org/tests/2414941 https://openqa.opensuse.org/tests/2414947; do MARKDOWN=1 openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/15095 $i; done

@okurz
Try to mitigate "VNC typing issues" with disabled key repeat
4547579 
Independent of fixing the actual performance problems I think it can
help in general for openQA tests if we configure the systems we test in
with a disabled key repeat to mitigate the issues, i.e. "xset -r"
within at least X11 sessions.

This commit is adding a new method in the "x11test" base class and is
using that in a dedicated module that should be scheduled right after we
ensured the desktop runner to be responsive and usable.

Related progress issue: https://progress.opensuse.org/issues/110542
@okurz
Add 'x11/setup' with disabled key repetition to schedules
22a2424
@okurz okurz mentioned this pull request Jun 15, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited by okurz
Loading

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files

@okurz okurz marked this pull request as draft June 15, 2022 15:05
@okurz okurz marked this pull request as ready for review June 15, 2022 16:56
@kalikiana
Copy link
Member

Verification runs:

for i in https://openqa.opensuse.org/tests/2415152 https://openqa.opensuse.org/tests/2414998 https://openqa.opensuse.org/tests/2415293 https://openqa.opensuse.org/tests/2414950 https://openqa.opensuse.org/tests/2415061 https://openqa.opensuse.org/tests/2414941 https://openqa.opensuse.org/tests/2414947; do MARKDOWN=1 openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/15095 $i; done

https://openqa.opensuse.org/tests/2417333#step/user_gui_login/3

Seems like this still ended up typing lxsession-logoutogout in the run dialog.

@okurz
Copy link
Member Author

okurz commented Jun 21, 2022

Seems like this still ended up typing lxsession-logoutogout in the run dialog.

which is not key repetition and must be something different.

@okurz
Copy link
Member Author

okurz commented Jun 29, 2022

@os-autoinst/tests-maintainer this should help you in many cases. Anyone interested to review additionally?

@ggardet
Copy link
Collaborator

ggardet commented Jun 29, 2022

I think this should help and is safe to merge.

@okurz okurz merged commit a99addd into os-autoinst:master Jun 30, 2022
@okurz okurz deleted the feature/prevent_key_repetition branch June 30, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalikiana kalikiana kalikiana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@okurz @kalikiana @ggardet