Leave an empty line between pod and code to all the files under lib #15139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
|
Why not to try to add the script that you used somewhere in the tools folder and call it from the Makefile? |
CI is the next step. thats why is still draft as not complete |
mpagot
reviewed
Jun 23, 2022
okurz
requested changes
Jun 23, 2022
okurz
approved these changes
Jun 24, 2022
b10n1k
force-pushed
the
pod_rule
branch
2 times, most recently
from
f19f22d
to
490fa36
Compare
mpagot
approved these changes
Jun 27, 2022
b10n1k
force-pushed
the
pod_rule
branch
3 times, most recently
from
0b35bd5
to
1901408
Compare
Following the recommendation all the perl POD documentation should have a empty line before the beginning of the code as a good practice. In this PR all the files which found under lib directory and its subdirectories are adding a new line from all the cases which matched `=cut\nsub` Signed-off-by: Ioannis Bonatakis <ybonatakis@suse.com>
As a convention the POD and the code needs to have an empty line in between. The script checks all the files rather the commit files in the lib directory. With this PR we enable validation of the rule in CI Signed-off-by: Ioannis Bonatakis <ybonatakis@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the recommendation all the perl POD documentation should have a
empty line before the beginning of the code as a good practice. In this PR all
the files which found under lib directory and its subdirectories are adding a
new line from all the cases which matched
=cut\nsubSigned-off-by: Ioannis Bonatakis ybonatakis@suse.com