Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate first steps in qam-yast_self_update+15 to libyui REST #15143

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Migrate first steps in qam-yast_self_update+15 to libyui REST #15143

merged 1 commit into from
Aug 23, 2022

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Jun 23, 2022 •
edited
Loading

Apply libyui-REST for yast qam self-update install tests. Intended to replace qam-yast-self-update.yaml only on >= 15SP3

@ilmanzo ilmanzo changed the title [WIP] Poo#112574 migrate qam yast self update+15 [WIP] migrate qam yast self update+15 Jun 24, 2022
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch from a7992cc to e8a3b62 Compare June 24, 2022 09:29
jknphy
jknphy reviewed Jun 24, 2022
View reviewed changes
Copy link
Contributor

@jknphy jknphy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main point missing is adding the updates, for that we still don't have libyui-rest module available and I have some plan to do it, so we can postpone, only the few modules at the beginning are needed.

we would need verification for SP3 and SP4, including uefi flavor.
Additionally we would need a PR for setup this test suite in Development group:
https://gitlab.suse.de/qa-maintenance/qam-openqa-yml/-/blob/master/JobGroups/yast/maint_updates_devel.yml

schedule/qam/common/qam-yast_self_update_with_libyui-rest.yaml Outdated Show resolved Hide resolved
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch from 0afc43c to cf27035 Compare June 24, 2022 10:07
@jknphy jknphy added the qe-yast label Jun 24, 2022
@ilmanzo
Copy link
Contributor Author

ilmanzo commented Jun 24, 2022 •
edited
Loading

created merge request on gitlab
https://gitlab.suse.de/qa-maintenance/qam-openqa-yml/-/merge_requests/298

@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch from 14f4b8f to 8c00b32 Compare June 24, 2022 13:00
@ilmanzo ilmanzo changed the title [WIP] migrate qam yast self update+15 migrate qam yast self update+15 Jul 6, 2022
@ilmanzo ilmanzo marked this pull request as ready for review July 6, 2022 08:04
jknphy
jknphy reviewed Jul 12, 2022
View reviewed changes
Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message and the PR title should follow some basic rules, it should start by capital letter and should be some sentences with no commas, something meaningful like:
Migrate first steps in qam-yast_self_update+15 to libyui REST
The reason for that is that some contributors use git log to check the commits and should be easy to understand the changes and the scope of those from there as well, not only checking gitlab. Some references:
https://commit.style/
https://cbea.ms/git-commit/

schedule/qam/common/qam-yast_self_update_libyui-rest.yaml Outdated Show resolved Hide resolved
schedule/qam/common/qam-yast_self_update_libyui-rest.yaml Outdated Show resolved Hide resolved
@jknphy
Copy link
Contributor

jknphy commented Jul 12, 2022 •
edited
Loading

created merge request on gitlab https://gitlab.suse.de/qa-maintenance/qam-openqa-yml/-/merge_requests/298

we usually gather all this info in the first comment of the PR, so we have all the links available at the top.

@ilmanzo ilmanzo changed the title migrate qam yast self update+15 Migrate first steps in qam-yast_self_update+15 to libyui REST Jul 24, 2022
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch 2 times, most recently from c32ddbf to 2864f66 Compare July 25, 2022 13:26
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch from 2864f66 to 4496451 Compare August 8, 2022 11:34
@ilmanzo ilmanzo changed the title Migrate first steps in qam-yast_self_update+15 to libyui REST [WIP] Migrate first steps in qam-yast_self_update+15 to libyui REST Aug 8, 2022
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch 6 times, most recently from bcc2dfe to 4d038c4 Compare August 12, 2022 09:59
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch from 4d038c4 to dd01c0d Compare August 17, 2022 06:46
@ilmanzo ilmanzo changed the title [WIP] Migrate first steps in qam-yast_self_update+15 to libyui REST Migrate first steps in qam-yast_self_update+15 to libyui REST Aug 17, 2022
jknphy
jknphy reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking really good, some feedback.

tests/installation/module_registration/register_modules.pm Outdated Show resolved Hide resolved
tests/installation/module_registration/register_modules.pm Outdated Show resolved Hide resolved
tests/installation/module_registration/register_modules.pm Outdated Show resolved Hide resolved
tests/installation/module_registration/register_modules.pm Outdated Show resolved Hide resolved
tests/installation/module_registration/register_modules.pm Outdated Show resolved Hide resolved
lib/Installation/ModuleRegistration/ModuleRegCodeController.pm Outdated Show resolved Hide resolved
lib/Installation/ModuleRegistration/ModuleRegCodeController.pm Outdated Show resolved Hide resolved
schedule/qam/common/qam-yast_self_update_libyui-rest.yaml Outdated Show resolved Hide resolved
lib/Installation/ModuleRegistration/ModuleRegistrationPage.pm Show resolved Hide resolved
lib/Installation/ModuleRegistration/ModuleRegistrationPage.pm Outdated Show resolved Hide resolved
@ilmanzo ilmanzo changed the title Migrate first steps in qam-yast_self_update+15 to libyui REST [WIP] Migrate first steps in qam-yast_self_update+15 to libyui REST Aug 17, 2022
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch 4 times, most recently from bb0ecdf to e18d2fa Compare August 17, 2022 15:18
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch from e18d2fa to 5988302 Compare August 17, 2022 15:58
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch 5 times, most recently from f27bc38 to 918a6d4 Compare August 19, 2022 10:10
@ilmanzo ilmanzo changed the title [WIP] Migrate first steps in qam-yast_self_update+15 to libyui REST Migrate first steps in qam-yast_self_update+15 to libyui REST Aug 19, 2022
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch from 918a6d4 to d7ab6d5 Compare August 19, 2022 11:58
@ilmanzo
Change needle-based installation testing to libyui
1f969d5 
Perform testing with libyui REST API since the version of the product where it is
available, SP3 and above.

Related ticket: https://progress.opensuse.org/issues/112574
@ilmanzo ilmanzo force-pushed the poo#112574_Migrate-qam-yast_self_update+15 branch from d7ab6d5 to 1f969d5 Compare August 22, 2022 07:29
@jknphy
Copy link
Contributor

jknphy commented Aug 23, 2022

Good job!
Clean code, well discussed specially the part about make the exception to drive the code by settings only for addons, and you even did the extra mile making it more consistent with previous work.

@jknphy jknphy merged commit 9918bb2 into os-autoinst:master Aug 23, 2022
@ilmanzo ilmanzo deleted the poo#112574_Migrate-qam-yast_self_update+15 branch August 23, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jknphy jknphy jknphy left review comments

@coolgw coolgw coolgw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ilmanzo @jknphy @coolgw