Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 support for swtpm test #15145

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Add aarch64 support for swtpm test #15145

merged 1 commit into from
Jun 27, 2022

Conversation

STARRY-S
Copy link
Contributor

@STARRY-S STARRY-S commented Jun 23, 2022

Updated test code to add aarch64 support of swtpm tests by running tests on Raspberry Pi4.

The flavor of create_swtpm_hdd_aarch is DVD, and the flavor of security_swtpm_jeos_rpi4 is JeOS-for-RPi,
I can not add START_AFTER_TEST dependencies between these two tests since they use different flavors,
and I also can not set the flavor of create_swtpm_hdd_aarch to JeOS-for-RPi since it needs to start
after create_hdd_textmode@aarch64.
So I updated the test code in swtpm_env_setup.pm to check the status of create_swtpm_hdd_aarch by using openQA API.

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files

@STARRY-S STARRY-S marked this pull request as ready for review June 23, 2022 07:59
@STARRY-S STARRY-S changed the title [WIP] Add aarch64 support for swtpm test Add aarch64 support for swtpm test Jun 23, 2022
data/swtpm/ssh_port_chk_script Show resolved Hide resolved
data/swtpm/ssh_port_chk_script Show resolved Hide resolved
lib/swtpmtest.pm Outdated Show resolved Hide resolved
lib/swtpmtest.pm Outdated Show resolved Hide resolved
lib/swtpmtest.pm Outdated Show resolved Hide resolved
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RoyCai7 RoyCai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jouyingbin
Copy link
Contributor

jouyingbin commented Jun 24, 2022

@STARRY-S
In the description security_swtpm_jeos: https://openqa.opensuse.org/tests/2433598#

Would you add the RPi character in the sentence, it would be easier to recognize for the running job on RPi.
but it is not mandatory. :)

@STARRY-S
Copy link
Contributor Author

Would you add the RPi character in the sentence, it would be easier to recognize for the running job on RPi.

Done, thanks for the comments XD.

@jouyingbin
Copy link
Contributor

jouyingbin commented Jun 24, 2022

Would you add the RPi character in the sentence, it would be easier to recognize for the running job on RPi.

Done, thanks for the comments XD.

And the name also nice to chang to something like

security_swtpm_jeos_(RPi4)

Since aarch64 and RPi backend are different in openQA.
how do you think ?

@jouyingbin
Copy link
Contributor

Others LGTM, good job.

@STARRY-S
Copy link
Contributor Author

STARRY-S commented Jun 24, 2022

And the name also nice to chang to something like

security_swtpm_jeos_(RPi4)

Since aarch64 and RPi backend are different in openQA. how do you think ?

Sure, I use (get_var('MACHINE') =~ /RPi4/ to check the test is running on RPi4 or not,
so let me rename this test to security_swtpm_jeos_rpi4 (lowercase is easier to remember I think XD)
and re-trigger these test cases later.

Updated test code to run swtpm tests on raspberry pi 4 for adding
aarch64 support.
@STARRY-S
Copy link
Contributor Author

and re-trigger these test cases later.

Done, passed successfully: https://openqa.opensuse.org/tests/2433943#

@Amrysliu Amrysliu merged commit d0b303b into os-autoinst:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants