Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm autoyast creation is removed from installation overview #1521

Merged
merged 1 commit into from
Jul 18, 2016

Conversation

kravciak
Copy link
Contributor

@okurz
Copy link
Member

okurz commented Jul 14, 2016

Please provide a link or screenshot to a local verification run.

# Check autoyast has been removed in SP2
if (get_var("SP2ORLATER")) {
send_key 'tab';
send_key 'pgdn';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, what happens e.g. in an allpatterns scenario when the installation overview covers more than the one-and-half pages that you would reach with one press of "pgdn"? Take a look here: https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/tests/installation/installation_overview.pm#L58
Wouldn't this also make sense here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would 'end' work better instead of 'pgdn'?

@kravciak kravciak force-pushed the autoyast branch 2 times, most recently from a5564a0 to 16b63b6 Compare July 15, 2016 11:59
@kravciak
Copy link
Contributor Author

I could not find textmode installation with short installation overview, in other cases it should work fine.
textmode: http://dhcp91.suse.cz/tests/1563#step/installation_overview/2
allpatterns: http://dhcp91.suse.cz/tests/1564#step/installation_overview/10
minimal: http://dhcp91.suse.cz/tests/1548#step/installation_overview/10
extratests: http://dhcp91.suse.cz/tests/1541#step/autoyast/1

@okurz
Copy link
Member

okurz commented Jul 15, 2016

Please add the date ref, I remember you already had this prepared locally :-)

@okurz
Copy link
Member

okurz commented Jul 18, 2016

s/date/fate/

@kravciak kravciak force-pushed the autoyast branch 2 times, most recently from 4103021 to cc5ade5 Compare July 18, 2016 09:13
@kravciak
Copy link
Contributor Author

done

@okurz okurz merged commit 4759c29 into os-autoinst:master Jul 18, 2016
@okurz
Copy link
Member

okurz commented Jul 18, 2016

needles have been merged, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants