Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use our own testsite in firefox html5 test #15228

Merged
merged 1 commit into from Jul 18, 2022
Merged

Use our own testsite in firefox html5 test #15228

merged 1 commit into from Jul 18, 2022

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Jul 15, 2022

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files

@asdil12
Copy link
Member Author

asdil12 commented Jul 15, 2022 •
edited

https://openqa.suse.de/tests/9132731#step/firefox_html5/11

@asdil12 asdil12 marked this pull request as ready for review July 15, 2022 10:25
@asdil12
Copy link
Member Author

asdil12 commented Jul 15, 2022

Note that before merging I need to fix the order of the test nodules to something that makes more sense.

@asdil12 asdil12 added the WIP Work in progress label Jul 15, 2022
@asdil12 asdil12 force-pushed the html5 branch 6 times, most recently from 193b51a to 5d04dcf Compare July 15, 2022 13:23
@asdil12 asdil12 removed the WIP Work in progress label Jul 15, 2022
@asdil12
Copy link
Member Author

asdil12 commented Jul 15, 2022

That looks quite well: https://openqa.suse.de/tests/9138441#step/firefox_html5/17

@asdil12 asdil12 requested a review from foursixnine July 18, 2022 08:04
@asdil12 asdil12 merged commit 1dcc3f8 into os-autoinst:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloviska mloviska mloviska left review comments

@foursixnine foursixnine foursixnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@asdil12 @foursixnine @mloviska