Delete drawboard function from WebSocketsTest #15278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to poo#114532, in the sake of stability, that we can safely delete the function that tests the drawboard example. We already cover the rest of Tomcat's WebSocket examples, and, in reality, this drawboard example is not really tested with multiple connections as it would ideally be the case. At the same time, increase the timeout value for some tomcat test modules to reduce the impact by performance.
rfan1
force-pushed
the
tomcat_multiplayer_drawboard
branch
from
83a6bcb
to
654fe81
Compare
|
you can remove from commit msg: |
a-kpappas
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to poo#114532, in the sake of stability, that we can safely
delete the function that tests the drawboard example.
We already cover the rest of Tomcat's WebSocket examples,
and, in reality, this drawboard example is not really tested
with multiple connections as it would ideally be the case.
At the same time, increase the timeout value for some tomcat
test modules to reduce the impact by performance.