Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new test for validation of ZFCP multipath configuration #15326

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Aug 5, 2022

After #poo105440 that enabled a new multipath topology on S390x, this test validates the updated infrastructure

@ilmanzo ilmanzo force-pushed the poo_105449_new_test_module_for_testing_multipath branch from c2a4b8d to 88b2afe Compare August 5, 2022 12:22
@ilmanzo ilmanzo changed the title [WIP] Add new test for validation of ZFCP multipath configuration Add new test for validation of ZFCP multipath configuration Aug 8, 2022
@jknphy
Copy link
Contributor

jknphy commented Aug 9, 2022

the goal is not validate the infrastructure but to know if the installer handle properly zfcp+multipath, it might be ok to do this early validation during installation but the validation should go in the installed system IMO or I am missing something...?

@ilmanzo
Copy link
Contributor Author

ilmanzo commented Aug 9, 2022

quote from the ticket: "The idea is to check the status of the known infrastructure, and the status of multipathing on top of it."

as the installation does not make any use of multipath block devices, and given there's already the ZFCP validation in place, we can surely move this test after the reboot step ...

tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
tests/installation/validate_zfcp_multipath.pm Outdated Show resolved Hide resolved
@ilmanzo ilmanzo force-pushed the poo_105449_new_test_module_for_testing_multipath branch 4 times, most recently from dc19ab5 to 69aa514 Compare August 11, 2022 09:58
@jknphy
Copy link
Contributor

jknphy commented Aug 11, 2022

LGTM, good job, looks very clear to dissect problems now.
waiting for VR succeded to merge (please, set to WIP if you want me to stop the merge due to you are performing some late minute changes or something, and remove the WIP when you are finished)

@ilmanzo ilmanzo changed the title Add new test for validation of ZFCP multipath configuration [WIP] Add new test for validation of ZFCP multipath configuration Aug 11, 2022
@ilmanzo ilmanzo force-pushed the poo_105449_new_test_module_for_testing_multipath branch from 0ab6b52 to a313f15 Compare August 11, 2022 12:44
@ilmanzo ilmanzo changed the title [WIP] Add new test for validation of ZFCP multipath configuration Add new test for validation of ZFCP multipath configuration Aug 11, 2022
@jknphy jknphy merged commit 20a06e9 into os-autoinst:master Aug 12, 2022
@ilmanzo ilmanzo deleted the poo_105449_new_test_module_for_testing_multipath branch August 12, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants