Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to libyui REST API yast2 scc #15333

Merged
merged 1 commit into from Sep 8, 2022
Merged

Migrate to libyui REST API yast2 scc #15333

merged 1 commit into from Sep 8, 2022

Conversation

coolgw
Copy link
Contributor

@coolgw coolgw commented Aug 8, 2022 •
edited

Migrate to libyui REST API yast2 scc

For select_modules_and_patterns+registration, run aarch64 and ppc64le result is ok.
s390 can't run since 151.1 repo already not exist(Pass case) and we have ticket blocked on latest build.
sle-15-SP5-Full-aarch64-Build15.2-select_modules_and_patterns+registration@aarch64 -> https://openqa.suse.de/t9411438
set priority for 9411438
sle-15-SP5-Full-ppc64le-Build15.2-select_modules_and_patterns+registration@ppc64le -> https://openqa.suse.de/t9411439
set priority for 9411439

@coolgw coolgw added WIP Work in progress qe-yast labels Aug 8, 2022
@coolgw coolgw force-pushed the libyui branch 2 times, most recently from dfbd719 to 0c57a19 Compare August 8, 2022 09:41
@jknphy jknphy changed the title WIP Migrate to libyui REST API yast2 scc WIP: Migrate to libyui REST API yast2 scc Aug 10, 2022
@coolgw coolgw force-pushed the libyui branch 18 times, most recently from d1c06b5 to 6c44c2b Compare August 23, 2022 11:49
@coolgw coolgw removed the WIP Work in progress label Aug 23, 2022
@coolgw coolgw changed the title WIP: Migrate to libyui REST API yast2 scc Migrate to libyui REST API yast2 scc Aug 23, 2022
jknphy
jknphy reviewed Aug 24, 2022
View reviewed changes
tests/x11/addon_products_via_SCC_yast2.pm Outdated Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Outdated Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Show resolved Hide resolved
@coolgw coolgw force-pushed the libyui branch 2 times, most recently from a77a8c4 to bc94b24 Compare August 24, 2022 06:53
@coolgw coolgw added the WIP Work in progress label Aug 24, 2022
@coolgw coolgw force-pushed the libyui branch 10 times, most recently from d055225 to 5ce0764 Compare August 25, 2022 06:32
@coolgw coolgw removed the WIP Work in progress label Aug 25, 2022
@jknphy
Copy link
Contributor

jknphy commented Aug 29, 2022 •
edited

we need to cover all the architectures where this is running, there are different yaml schedules under:
schedule/yast/select_modules_and_patterns+registration/
https://openqa.suse.de/tests/overview?arch=&flavor=Full&machine=&test=&modules=suseconnect_scc&module_re=&distri=sle&version=15-SP4&build=151.1&groupid=129#

MR for AC2 in https://progress.opensuse.org/issues/108227 ?

jknphy
jknphy reviewed Aug 29, 2022
View reviewed changes
tests/x11/addon_products_via_SCC_yast2.pm Outdated Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Outdated Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Outdated Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Outdated Show resolved Hide resolved
@coolgw coolgw force-pushed the libyui branch 6 times, most recently from 24b1c10 to bf7f355 Compare August 30, 2022 04:58
@coolgw
Copy link
Contributor Author

coolgw commented Aug 30, 2022

we need to cover all the architectures where this is running, there are different yaml schedules under: schedule/yast/select_modules_and_patterns+registration/ https://openqa.suse.de/tests/overview?arch=&flavor=Full&machine=&test=&modules=suseconnect_scc&module_re=&distri=sle&version=15-SP4&build=151.1&groupid=129#

MR for AC2 in https://progress.opensuse.org/issues/108227 ?

For select_modules_and_patterns+registration, run aarch64 and ppc64le result is ok. s390 can't run since 151.1 repo already not exist(Pass case) and we have ticket blocked on latest build.
sle-15-SP5-Full-aarch64-Build15.2-select_modules_and_patterns+registration@aarch64 -> https://openqa.suse.de/t9411438
set priority for 9411438
sle-15-SP5-Full-ppc64le-Build15.2-select_modules_and_patterns+registration@ppc64le -> https://openqa.suse.de/t9411439
set priority for 9411439

https://gitlab.suse.de/qsf-y/qa-sle-functional-y/-/merge_requests/413

@coolgw coolgw requested a review from jknphy August 30, 2022 07:35
jknphy
jknphy reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the maximize comment that might break stuff, the other comments are cosmetics if you would like to address them, after that, ready to go! the test code layer looks very clean. good job!

tests/x11/addon_products_via_SCC_yast2.pm Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Show resolved Hide resolved
lib/Installation/ModuleRegistration/ModuleRegistrationInstallationReportController.pm Outdated Show resolved Hide resolved
lib/Installation/ModuleRegistration/ModuleRegistrationInstallationReportPage.pm Outdated Show resolved Hide resolved
lib/YaST/Module.pm Outdated Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Show resolved Hide resolved
tests/x11/addon_products_via_SCC_yast2.pm Show resolved Hide resolved
@coolgw
Copy link
Contributor Author

coolgw commented Sep 8, 2022

Latest sanity check VR:
https://openqa.suse.de/tests/9474913#details

@jknphy
Copy link
Contributor

jknphy commented Sep 8, 2022

Very neat, good job!

@jknphy jknphy merged commit 0e189f4 into os-autoinst:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jknphy jknphy jknphy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@coolgw @jknphy