Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture installed and uninstalled packages during test #15340

Merged
merged 1 commit into from Aug 15, 2022

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Aug 9, 2022

Ticket: http://kazhua.qa.suse.de/tests/127
Verification: http://kazhua.qa.suse.de/tests/127
Example JSON: http://kazhua.qa.suse.de/tests/130/file/zypper_packages.json

{
   "commands" : [
      {
         "action" : "install",
         "packages" : [
            "tmux",
            "htop",
            "perl-Perl-Tidy"
         ],
         "raw_command" : "in tmux htop perl-Perl-Tidy",
         "return_code" : 0,
         "test" : {
            "category" : "console",
            "module" : "zypper_log_packages"
         }
      },
      {
         "action" : "remove",
         "packages" : [
            "perl-Perl-Tidy"
         ],
         "raw_command" : "rm perl-Perl-Tidy",
         "return_code" : 0,
         "test" : {
            "category" : "console",
            "module" : "zypper_log_packages"
         }
      }
   ],
   "individual_pkgs" : [
      {
         "action" : "install",
         "arch" : "x86_64",
         "package" : "htop",
         "release" : "1.1",
         "version" : "3.2.1"
      },
      {
         "action" : "install",
         "arch" : "x86_64",
         "package" : "libutf8proc2",
         "release" : "1.3",
         "version" : "2.7.0"
      },
      {
         "action" : "install",
         "arch" : "noarch",
         "package" : "perl-Perl-Tidy",
         "release" : "1.2",
         "version" : "20220613"
      },
      {
         "action" : "install",
         "arch" : "x86_64",
         "package" : "tmux",
         "release" : "1.1",
         "version" : "3.3a"
      },
      {
         "action" : "remove",
         "arch" : "noarch",
         "package" : "perl-Perl-Tidy",
         "release" : "1.2",
         "version" : "20220613"
      }
   ]
}

@github-actions
Copy link

github-actions bot commented Aug 10, 2022

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

Files matching t/data/test_schedule.out:

  • Ensure openSUSE/SLE release managers are ok with the change in staging schedule

This is an automatically generated QA checklist based on modified files

@asdil12
Copy link
Member Author

asdil12 commented Aug 10, 2022

Copy link
Contributor

@Avinesh Avinesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asdil12, Does this also takes care of the packages which gets installed as dependencies?

@asdil12
Copy link
Member Author

asdil12 commented Aug 11, 2022

Hi @asdil12, Does this also takes care of the packages which gets installed as dependencies?

Yes - they are listed in the individual_pkgs list.

@asdil12 asdil12 force-pushed the zlog branch 2 times, most recently from 063bd81 to c6fc3b6 Compare August 11, 2022 12:22
@asdil12
Copy link
Member Author

asdil12 commented Aug 11, 2022

[root@kazhua ~]# openqa-clone-custom-git-refspec #15340 https://openqa.opensuse.org/tests/2506337
Github oauth token provided, performing authenticated requests
Created job #2508966: opensuse-Tumbleweed-DVD-x86_64-Build20220809-gnome@64bit -> https://openqa.opensuse.org/t2508966
[root@kazhua ~]# openqa-clone-custom-git-refspec #15340 https://openqa.suse.de/tests/9304453
Github oauth token provided, performing authenticated requests
Created job #9315189: sle-15-SP5-Online-x86_64-Build9.1-default@64bit -> https://openqa.suse.de/t9315189

@rfan1
Copy link
Contributor

rfan1 commented Aug 15, 2022

@asdil12
One minor comment, based on your example, "package" : "libutf8proc2" should be installed as dependency. Could we add some checkpoint for this type of packages?

@asdil12
Copy link
Member Author

asdil12 commented Aug 15, 2022

@asdil12 One minor comment, based on your example, "package" : "libutf8proc2" should be installed as dependency. Could we add some checkpoint for this type of packages?

I'm not sure what you mean

Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfan1
Copy link
Contributor

rfan1 commented Aug 15, 2022

@asdil12 One minor comment, based on your example, "package" : "libutf8proc2" should be installed as dependency. Could we add some checkpoint for this type of packages?

I'm not sure what you mean

As we discussed offline, it is fine not need to highlight the packages installed as dependency. LGTM

@asdil12 asdil12 merged commit bb96dd4 into os-autoinst:master Aug 15, 2022
@DimStar77
Copy link
Contributor

https://openqa.opensuse.org/tests/2524832#step/zypper_log_packages/10

On PPC I see this zypper_log_packages failing quite often

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants