Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zypper refresh timeout in zypper_lifecycle #15367

Merged
merged 1 commit into from Aug 22, 2022

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Aug 15, 2022

Enhance the current logic not to remove the zypper cache.

@okurz
Copy link
Member

okurz commented Aug 15, 2022

s/timout/timeout/

And you created a pull request which has the template text included

@asdil12
Copy link
Member

asdil12 commented Aug 15, 2022

The patch itself looks fine

@rfan1
Copy link
Contributor Author

rfan1 commented Aug 16, 2022

s/timout/timeout/

And you created a pull request which has the template text included

Thanks @okurz, deleted that line.

@rfan1
Copy link
Contributor Author

rfan1 commented Aug 16, 2022

The issue can be seen on s390x and aarch64 platforms in the latest build, let me try to test them as well.

@rfan1 rfan1 changed the title Increase zypper refresh timout in zypper_lifesycle [wip]Increase zypper refresh timout in zypper_lifesycle Aug 16, 2022
@okurz
Copy link
Member

okurz commented Aug 16, 2022

two more typos lifesycle and preparse. Please be more careful with the spelling. The git history is an important reference for future research and it's very hard to find corresponding changes by search term if not correctly written.

@rfan1
Copy link
Contributor Author

rfan1 commented Aug 16, 2022

two more typos lifesycle and preparse. Please be more careful with the spelling. The git history is an important reference for future research and it's very hard to find corresponding changes by search term if not correctly written.

Thanks, let me fix the typo in the code as well

@rfan1 rfan1 changed the title [wip]Increase zypper refresh timout in zypper_lifesycle Increase zypper refresh timout in zypper_lifesycle Aug 16, 2022
@rfan1 rfan1 changed the title Increase zypper refresh timout in zypper_lifesycle Increase zypper refresh timout in zypper_lifecycle Aug 16, 2022
@rfan1 rfan1 changed the title Increase zypper refresh timout in zypper_lifecycle Increase zypper refresh timeout in zypper_lifecycle Aug 16, 2022
@rfan1 rfan1 changed the title Increase zypper refresh timeout in zypper_lifecycle [WIP]Increase zypper refresh timout in zypper_lifecycle Aug 17, 2022
@rfan1
Copy link
Contributor Author

rfan1 commented Aug 17, 2022

Hold on this PR, I need to investigate why we delete the zypper cache, and to see if we can enhance current logic
` select_console 'root-console';

 # First we'd make sure that we have a clean zypper cache env and all dirs have
 # 0755 and all files have 0644 pemmission.
 # For some reason the system will change the permission on /var/cache/zypp/{solv,raw}
 # files. this cause the zypper lifecycle failed when building cache for non-root user.
 script_run('rm -fr /var/cache/zypp/solv /var/cache/zypp/solv');
 script_run('rm -fr /var/cache/zypp/raw /var/cache/zypp/raw');`

@rfan1 rfan1 force-pushed the zypper_lifecycle_timeout branch 2 times, most recently from 36ef327 to f58d0d8 Compare August 17, 2022 06:30
@rfan1 rfan1 changed the title [WIP]Increase zypper refresh timout in zypper_lifecycle [wip]Fix zypper refresh timeout in zypper_lifecycle Aug 17, 2022
@rfan1 rfan1 changed the title [WIP]Increase zypper refresh timout in zypper_lifecycle [WIP]fix zypper refresh timeout in zypper_lifecycle Aug 17, 2022
@rfan1 rfan1 changed the title [WIP]fix zypper refresh timeout in zypper_lifecycle fix zypper refresh timeout in zypper_lifecycle Aug 17, 2022
@a-kpappas a-kpappas self-requested a review August 17, 2022 12:29
@a-kpappas
Copy link
Contributor

Why is it script_run "zypper refresh" and not assert_script_run?

@rfan1
Copy link
Contributor Author

rfan1 commented Aug 18, 2022

Why is it script_run "zypper refresh" and not assert_script_run?

Good question, as discussed with @hjluo, we don't have to make sure zypper fresh command get return code 0 for later tests.
just try to sync the repositories and then zypper lifecycle throws away everything

@rfan1 rfan1 changed the title fix zypper refresh timeout in zypper_lifecycle [wip]fix zypper refresh timeout in zypper_lifecycle Aug 18, 2022
@asdil12
Copy link
Member

asdil12 commented Aug 18, 2022

Why is it script_run "zypper refresh" and not assert_script_run?

If at all, it should be:

zypper_call "refresh";

@rfan1 rfan1 changed the title [wip]fix zypper refresh timeout in zypper_lifecycle fix zypper refresh timeout in zypper_lifecycle Aug 19, 2022
Enhance the current logic not to remove the zypper cache.
Please refer to poo#115292.
@a-kpappas a-kpappas merged commit 1b820cc into os-autoinst:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants