Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/network/firewalld_policy_objects: Contact the right openQA host #15372

Merged
merged 2 commits into from Aug 17, 2022

Conversation

Vogtinator
Copy link
Member

@Vogtinator Vogtinator commented Aug 16, 2022

The client and server VMs are possibly on other openQA workers than the
firewall, but they need to access their actual worker through 10.0.2.2 for
asset download and upload. Add an explicit route for that and rely on IP
rewriting done by OpenVSwitch.

Hopefully this fixes the remaining random firewalld test failures.

https://progress.opensuse.org/issues/115313#note-3

Depends on #15371

Verification runs:

https://openqa.opensuse.org/tests/2517890
https://openqa.opensuse.org/tests/2517926

Apparently there's a delay between "nmcli networking on" and the interface
getting the configuration assigned. Wait for that to happen.
The client and server VMs are possibly on other openQA workers than the
firewall, but they need to access their actual worker through 10.0.2.2 for
asset download and upload. Add an explicit route for that and rely on IP
rewriting done by OpenVSwitch.
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files

@Vogtinator Vogtinator requested review from pdostal, cfconrad and michaelgrifalconi and removed request for pdostal August 16, 2022 12:39
@Vogtinator Vogtinator marked this pull request as ready for review August 16, 2022 12:47
Copy link
Contributor

@michaelgrifalconi michaelgrifalconi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not feeling expert enough to give you a real assessment, but at least it makes sense to me and I agree with your idea!

@Vogtinator Vogtinator merged commit 51f6b36 into os-autoinst:master Aug 17, 2022
@Vogtinator Vogtinator deleted the maybemmfix branch August 17, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants