Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split qam-minimal+base test #15407

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Split qam-minimal+base test #15407

merged 1 commit into from
Sep 9, 2022

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Aug 24, 2022 •
edited
Loading

Due to poo#115007, split ‘qam-minimal+base’ test into 2 parts,
then we don't need to re-run all test modules in case some test
failures.

I Need modify the test suite and jobgroup as well, https://gitlab.suse.de/qa-maintenance/qam-openqa-yml/-/merge_requests/362

@rfan1 rfan1 changed the title [wip]Split qam-minimal+base test Split qam-minimal+base test Aug 25, 2022
@michaelgrifalconi
Copy link
Contributor

Looks great! Would still get a chance for other people to have a look before merging everything since is a relevant change.

I agree on having smaller parts to avoid image recreation on a small failure, will save us a lot of time!
I would like more a single schedule file, common for all versions but I see there are little differences here and there, and in any case it's out of scope and can be considered in future.

Thanks for the great work!

@foursixnine
Copy link
Member

@os-autoinst/tests-maintainer would you mind giving a review here? :)

@ge0r
Copy link
Member

ge0r commented Aug 29, 2022 •
edited
Loading

I would recommend for the first part of the split qam-minimal+base-installation, to implement it using autoyast for robustness. The interactive installation is already tested in yast, so if you only want this part for the image generation, autoyast would be a good fit.
Here is a small guide on how to generate the autoyast profile and then adjust it for your test, if the ones we already have in the repo won't do.

@rfan1
Copy link
Contributor Author

rfan1 commented Aug 29, 2022

I would recommend for the first part of the split qam-minimal+base-installation, to implement it using autoyast for robustness. The interactive installation is already tested in yast, so if you only want this part for the image generation, autoyast would be a good fit. Here is a small guide on how to generate the autoyast profile and then adjust it for your test, if the ones we already have in the repo won't do.

Why not, thanks much, let me try!

@rfan1 rfan1 changed the title Split qam-minimal+base test [wip]Split qam-minimal+base test Aug 31, 2022
@rfan1 rfan1 force-pushed the split-qam-minimal-base branch 9 times, most recently from 74955d5 to 71e26dc Compare September 7, 2022 02:42
@rfan1 rfan1 force-pushed the split-qam-minimal-base branch 5 times, most recently from 02cf53c to 365d551 Compare September 8, 2022 07:47
@rfan1
Split qam-minimal+base test
a71578f 
Due to poo#115007, split qam-minimal+base test into 2 parts,
then we don't need to re-run all test modules in case some test
failures.
@rfan1 rfan1 changed the title [wip]Split qam-minimal+base test Split qam-minimal+base test Sep 9, 2022
@rfan1
Copy link
Contributor Author

rfan1 commented Sep 9, 2022

@ge0r now installation is done via autoyast

ge0r
ge0r approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@ge0r ge0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ge0r
Copy link
Member

ge0r commented Sep 9, 2022

@ge0r now installation is done via autoyast

Nice work!

@rfan1
Copy link
Contributor Author

rfan1 commented Sep 9, 2022 •
edited
Loading

@foursixnine Could you please double check again?

Please merge my MR https://gitlab.suse.de/qa-maintenance/qam-openqa-yml/-/merge_requests/362 as well if you approve it :)

@foursixnine
Copy link
Member

@foursixnine Could you please double check again?

Please merge my MR https://gitlab.suse.de/qa-maintenance/qam-openqa-yml/-/merge_requests/362 as well if you approve it :)

Let's merge while playing:
Paint It Green

@foursixnine foursixnine merged commit 5ed2081 into os-autoinst:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foursixnine foursixnine foursixnine approved these changes

@ge0r ge0r ge0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rfan1 @michaelgrifalconi @foursixnine @ge0r