Enhance the redis test to know the status of the replication #15512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdostal
force-pushed
the
redis_enhance
branch
from
656564c
to
800493b
Compare
rfan1
reviewed
Sep 13, 2022
pdostal
force-pushed
the
redis_enhance
branch
from
800493b
to
e839895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
redis_cli.shscript as we should not use bash scripts in openQA unless absolutely needed. I also got rid ofbackground_script_run()asredis-serverhas parameter--deamonize yeswhich makes it running in background and logging to/var/log/redisinstead of/dev/stdout. Plusscript_retry()andvalidate_script_output_retry()should make the test more stable.